retry r210334 with fix for android

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 
 #include <algorithm>
 #include <map>
 #include <string>
 
@@ skipping 732 matching lines @@
     if (is_submitting_ || ShouldShowSpinner())
       return false;
     return true;
   }
 
   DCHECK_EQ(ui::DIALOG_BUTTON_CANCEL, button);
   return !is_submitting_ || autocheckout_state_ != AUTOCHECKOUT_NOT_STARTED ||
          IsSubmitPausedOn(wallet::VERIFY_CVV);
 }
 
+DialogOverlayState AutofillDialogControllerImpl::GetDialogOverlay() const {
+  bool show_wallet_interstitial = IsPayingWithWallet() && is_submitting_ &&
+      !IsSubmitPausedOn(wallet::VERIFY_CVV);
+  if (!show_wallet_interstitial)
+    return DialogOverlayState();
+
+  ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
+  DialogOverlayState state;
+  // TODO(estade): use the correct image and strings below.
+  state.image = rb.GetImageNamed(IDR_PRODUCT_LOGO_NAME_48);
+
+  state.strings.push_back(DialogOverlayString());
+  DialogOverlayString& string = state.strings.back();
+#if !defined(OS_ANDROID)

[Evan Stade, 2013/07/08 19:47:28]

here's the fix.

+  // gfx::Font isn't implemented on Android; DeriveFont() causes a null deref.
+  string.font = rb.GetFont(ui::ResourceBundle::BaseFont).DeriveFont(4);
+#endif
+
+  // First-run, post-submit, Wallet expository page.
+  if (full_wallet_ && full_wallet_->required_actions().empty()) {
+    string.text = ASCIIToUTF16("...consectetur adipisicing elit");
+
+    state.strings.push_back(DialogOverlayString());
+    DialogOverlayString& subtext = state.strings.back();
+    subtext.font = rb.GetFont(ui::ResourceBundle::BaseFont);
+    subtext.text = ASCIIToUTF16("sed do eiusmod tempor incididunt ut labore "
+        "et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud "
+        "exercitation ullamco laboris nisi ut aliquip ex ea commodo "
+        "consequat.");
+
+    state.button_text = ASCIIToUTF16("OK, gotcha");
+  } else {
+    // "Submitting" waiting page.
+    string.text = ASCIIToUTF16("Lorem ipsum dolor sit amet...");
+    string.alignment = gfx::ALIGN_CENTER;
+  }
+
+  return state;
+}
+
 const std::vector<ui::Range>& AutofillDialogControllerImpl::
     LegalDocumentLinks() {
   EnsureLegalDocumentsText();
   return legal_document_link_ranges_;
 }
 
 bool AutofillDialogControllerImpl::SectionIsActive(DialogSection section)
     const {
   if (IsSubmitPausedOn(wallet::VERIFY_CVV))
     return section == SECTION_CC_BILLING;
@@ skipping 1027 matching lines @@
   for (size_t i = 0; i < legal_document_link_ranges_.size(); ++i) {
     if (legal_document_link_ranges_[i] == range) {
       OpenTabWithUrl(wallet_items_->legal_documents()[i]->url());
       return;
     }
   }
 
   NOTREACHED();
 }
 
+void AutofillDialogControllerImpl::OverlayButtonPressed() {
+  DCHECK(is_submitting_);
+  DCHECK(full_wallet_);
+  profile_->GetPrefs()->SetBoolean(::prefs::kAutofillDialogHasPaidWithWallet,
+                                   true);
+  FinishSubmit();
+}
+
 void AutofillDialogControllerImpl::OnCancel() {
   HidePopup();
   if (autocheckout_state_ == AUTOCHECKOUT_NOT_STARTED && !is_submitting_)
     LogOnCancelMetrics();
   if (autocheckout_state_ == AUTOCHECKOUT_IN_PROGRESS) {
     GetMetricLogger().LogAutocheckoutDuration(
         base::Time::Now() - autocheckout_started_timestamp_,
         AutofillMetrics::AUTOCHECKOUT_CANCELLED);
   }
   callback_.Run(NULL, std::string());
@@ skipping 1243 matching lines @@
     if (*iter != wallet::INVALID_FORM_FIELD) {
       // TODO(dbeam): handle this more gracefully.
       DisableWallet(wallet::WalletClient::UNKNOWN_ERROR);
     }
   }
   SetAutocheckoutState(AUTOCHECKOUT_NOT_STARTED);
   SetIsSubmitting(false);
 }
 
 void AutofillDialogControllerImpl::FinishSubmit() {
+  if (IsPayingWithWallet() &&
+      !profile_->GetPrefs()->GetBoolean(
+            ::prefs::kAutofillDialogHasPaidWithWallet)) {
+    // To get past this point, the view must call back OverlayButtonPressed.
+#if defined(TOOLKIT_VIEWS)
+    view_->UpdateButtonStrip();
+#else
+    // TODO(estade): implement overlays on other platforms.
+    OverlayButtonPressed();
+#endif
+    return;
+  }
+
   FillOutputForSection(SECTION_EMAIL);
   FillOutputForSection(SECTION_CC);
   FillOutputForSection(SECTION_BILLING);
   FillOutputForSection(SECTION_CC_BILLING);
 
   if (ShouldUseBillingForShipping()) {
     FillOutputForSectionWithComparator(
         SECTION_BILLING,
         base::Bind(DetailInputMatchesShippingField));
     FillOutputForSectionWithComparator(
         SECTION_CC,
         base::Bind(DetailInputMatchesShippingField));
     FillOutputForSectionWithComparator(
         SECTION_CC_BILLING,
         base::Bind(DetailInputMatchesShippingField));
   } else {
     FillOutputForSection(SECTION_SHIPPING);
   }
 
-  if (IsPayingWithWallet()) {
-    profile_->GetPrefs()->SetBoolean(
-        ::prefs::kAutofillDialogHasPaidWithWallet, true);
-  } else {
+  if (!IsPayingWithWallet()) {
     for (size_t i = SECTION_MIN; i <= SECTION_MAX; ++i) {
       DialogSection section = static_cast<DialogSection>(i);
       if (!SectionIsActive(section))
         continue;
 
       SuggestionsMenuModel* model = SuggestionsMenuModelForSection(section);
       std::string item_key = model->GetItemKeyForCheckedItem();
       if (IsASuggestionItemKey(item_key) || item_key == kSameAsBillingKey) {
         int variant = GetSelectedVariantForModel(*model);
         PersistAutofillChoice(section, item_key, variant);
@@ skipping 205 matching lines @@
         AutofillMetrics::DIALOG_USER_SIGNED_IN_NO_WALLET_NO_AUTOFILL;
   }
 
   // Has Wallet items.
   return has_autofill_profiles ?
       AutofillMetrics::DIALOG_USER_SIGNED_IN_HAS_WALLET_HAS_AUTOFILL :
       AutofillMetrics::DIALOG_USER_SIGNED_IN_HAS_WALLET_NO_AUTOFILL;
 }
 
 }  // namespace autofill