Disable double tap zoom on mobile sites, to remove 300ms click delay

content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.content.Context;
 import android.os.Build;
 import android.os.Bundle;
 import android.os.SystemClock;
@@ skipping 1788 matching lines @@
         // If events are delivered at vsync, multiple SCROLL_BY and PINCH_BY events should still
         // trigger only a single vsync from any given call to confirmTouchEvent().
         if (inputEventsDeliveredAtVSync) {
             assertEquals(1, mMockMotionEventDelegate.mTotalSentLastGestureForVSyncCount);
         } else {
             assertEquals(0, mMockMotionEventDelegate.mTotalSentLastGestureForVSyncCount);
         }
    }
 
     /**
-     * Verify that no double tap gestures are created if the page has a fixed
-     * page scale.
+     * Verify that no double tap gestures are created if the gesture handler is
+     * told to disable double tap gesture detection (according to the logic in
+     * ContentViewCore.onRenderCoordinatesUpdated).
      * @throws Exception
      */
     @SmallTest
     @Feature({"Gestures"})
-    public void testNoDoubleTapWhenPageScaleFixed() throws Exception {
+    public void testNoDoubleTapWhenDoubleTapDisabled() throws Exception {
         final long downTime = SystemClock.uptimeMillis();
         final long eventTime = SystemClock.uptimeMillis();
 
         GestureRecordingMotionEventDelegate mockDelegate =
                 new GestureRecordingMotionEventDelegate();
         mGestureHandler = new ContentViewGestureHandler(
                 getInstrumentation().getTargetContext(), mockDelegate, mMockZoomManager,
                 ContentViewCore.INPUT_EVENTS_DELIVERED_AT_VSYNC);
-        mGestureHandler.updateHasFixedPageScale(true);
+        mGestureHandler.updateShouldDisableDoubleTap(true);
 
         MotionEvent event = MotionEvent.obtain(
                 downTime, downTime, MotionEvent.ACTION_DOWN,
                 FAKE_COORD_X, FAKE_COORD_Y, 0);
         assertTrue(mGestureHandler.onTouchEvent(event));
         assertEquals("Only GESTURE_TAP_DOWN should have been sent",
                 1, mockDelegate.mGestureTypeList.size());
 
         event = MotionEvent.obtain(
                 downTime, eventTime + 5, MotionEvent.ACTION_UP,
@@ skipping 23 matching lines @@
                 ContentViewGestureHandler.GESTURE_SINGLE_TAP_CONFIRMED,
                 mockDelegate.mMostRecentGestureEvent.mType);
         assertEquals("Only GESTURE_TAP_DOWN, " +
                 "GESTURE_SINGLE_TAP_CONFIRMED, " +
                 "GESTURE_TAP_DOWN and " +
                 "GESTURE_SINGLE_TAP_CONFIRMED should have been sent",
                 4, mockDelegate.mGestureTypeList.size());
     }
 
     /**
-     * Verify that double tap drag zoom feature is not invoked
-     * when the page scale is fixed. The second tap sequence should be
-     * treated just as the first would be.
+     * Verify that double tap drag zoom feature is not invoked when the gesture
+     * handler is told to disable double tap gesture detection (according to the
+     * logic in ContentViewCore.onRenderCoordinatesUpdated).
+     * The second tap sequence should be treated just as the first would be.
      * @throws Exception
      */
     @SmallTest
     @Feature({"Gestures"})
-    public void testNoDoubleTapDragZoomWhenPageScaleFixed() throws Exception {
+    public void testNoDoubleTapDragZoomWhenDoubleTapDisabled() throws Exception {
         final long downTime1 = SystemClock.uptimeMillis();
         final long downTime2 = downTime1 + 100;
 
         GestureRecordingMotionEventDelegate mockDelegate =
                 new GestureRecordingMotionEventDelegate();
         mGestureHandler = new ContentViewGestureHandler(
                 getInstrumentation().getTargetContext(), mockDelegate, mMockZoomManager,
                 ContentViewCore.INPUT_EVENTS_DELIVERED_AT_VSYNC);
-        mGestureHandler.updateHasFixedPageScale(true);
+        mGestureHandler.updateShouldDisableDoubleTap(true);
 
         MotionEvent event = motionEvent(MotionEvent.ACTION_DOWN, downTime1, downTime1);
         assertTrue(mGestureHandler.onTouchEvent(event));
 
         event = MotionEvent.obtain(
                 downTime1, downTime1 + 5, MotionEvent.ACTION_UP,
                 FAKE_COORD_X, FAKE_COORD_Y, 0);
         mGestureHandler.onTouchEvent(event);
 
         event = MotionEvent.obtain(
@@ skipping 32 matching lines @@
         event = MotionEvent.obtain(
                 downTime2, downTime2 + 15, MotionEvent.ACTION_UP,
                 FAKE_COORD_X, FAKE_COORD_Y + 200, 0);
         assertTrue(mGestureHandler.onTouchEvent(event));
         assertFalse("No GESTURE_PINCH_END should have been sent",
                 mockDelegate.mGestureTypeList.contains(
                         ContentViewGestureHandler.GESTURE_PINCH_END));
     }
 
     /**
-     * Verify that setting a fixed page scale during a double tap drag zoom disables
-     * double tap detection after the gesture has ended.
+     * Verify that setting a fixed page scale (or a mobile viewport) during a double
+     * tap drag zoom disables double tap detection after the gesture has ended.
      * @throws Exception
      */
     @SmallTest
     @Feature({"Gestures"})
     public void testFixedPageScaleDuringDoubleTapDragZoom() throws Exception {
         long downTime1 = SystemClock.uptimeMillis();
         long downTime2 = downTime1 + 100;
 
         GestureRecordingMotionEventDelegate mockDelegate =
                 new GestureRecordingMotionEventDelegate();
@@ skipping 19 matching lines @@
                 downTime2, downTime2 + 5, MotionEvent.ACTION_MOVE,
                 FAKE_COORD_X, FAKE_COORD_Y + 100, 0);
         assertTrue(mGestureHandler.onTouchEvent(event));
         assertTrue("GESTURE_SCROLL_START should have been sent",
                 mockDelegate.mGestureTypeList.contains(
                         ContentViewGestureHandler.GESTURE_SCROLL_START));
         assertEquals("GESTURE_PINCH_BEGIN should have been sent",
                 ContentViewGestureHandler.GESTURE_PINCH_BEGIN,
                 mockDelegate.mMostRecentGestureEvent.mType);
 
-        // Set a fixed page scale; this should not disrupt the current double-tap gesture.
-        mGestureHandler.updateHasFixedPageScale(true);
+        // Simulate setting a fixed page scale (or a mobile viewport);
+        // this should not disrupt the current double-tap gesture.
+        mGestureHandler.updateShouldDisableDoubleTap(true);
 
         // Double tap zoom updates should continue.
         event = MotionEvent.obtain(
                 downTime2, downTime2 + 10, MotionEvent.ACTION_MOVE,
                 FAKE_COORD_X, FAKE_COORD_Y + 200, 0);
         assertTrue(mGestureHandler.onTouchEvent(event));
         assertTrue("GESTURE_SCROLL_BY should have been sent",
                 mockDelegate.mGestureTypeList.contains(
                         ContentViewGestureHandler.GESTURE_SCROLL_BY));
         assertEquals("GESTURE_PINCH_BY should have been sent",
@@ skipping 53 matching lines @@
         event = MotionEvent.obtain(
                 downTime2, downTime2 + 15, MotionEvent.ACTION_UP,
                 FAKE_COORD_X, FAKE_COORD_Y + 200, 0);
         assertTrue(mGestureHandler.onTouchEvent(event));
         assertFalse("GESTURE_PINCH_END should not have been sent",
                 mockDelegate.mGestureTypeList.contains(
                         ContentViewGestureHandler.GESTURE_PINCH_END));
     }
 
 }