Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1884943004: [chromedriver] Prefix server logs with chromedriver_log_. (Closed)

Created:
4 years, 8 months ago by samuong
Modified:
4 years, 8 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Prefix server logs with chromedriver_log_. Since user data dirs are now prefixed with 'chromedriver_' (as of crrev.com/384032), the 'archive chromedriver server logs' step is getting confused between server log files and user data directories, and failing to archive logs. This CL prefixes log files so that they can be distinguished from other temp files/directories and uploaded correctly. BUG=chromedriver:1360 TBR=stgao@chromium.org Committed: https://crrev.com/b12684ee2772acf5ed9d1834b4cd66e83dd8da2b Cr-Commit-Position: refs/heads/master@{#387088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/run_buildbot_steps.py View 1 chunk +8 lines, -7 lines 0 comments Download
M chrome/test/chromedriver/test/run_all_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884943004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884943004/1
4 years, 8 months ago (2016-04-13 20:36:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 21:10:20 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b12684ee2772acf5ed9d1834b4cd66e83dd8da2b Cr-Commit-Position: refs/heads/master@{#387088}
4 years, 8 months ago (2016-04-13 21:13:02 UTC) #8
stgao
4 years, 8 months ago (2016-04-13 21:34:22 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698