Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: net/http/http_stream_parser.h

Issue 1884943003: HttpStreamParser: Don't reuse sockets which receive unparsed data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix drainer test ('True' means closed...) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_parser.h
diff --git a/net/http/http_stream_parser.h b/net/http/http_stream_parser.h
index b8bb23a20737d482bdb39b326bc913f56306ecca..ca3fd567f5c1e7698e22c6b16b86687a3485188f 100644
--- a/net/http/http_stream_parser.h
+++ b/net/http/http_stream_parser.h
@@ -223,10 +223,7 @@ class NET_EXPORT_PRIVATE HttpStreamParser {
// The amount of sent data.
int64_t sent_bytes_;
- // The parsed response headers. Owned by the caller of SendRequest. This
- // cannot be safely accessed after reading the final set of headers, as the
- // caller of SendRequest may have been destroyed - this happens in the case an
- // HttpResponseBodyDrainer is used.
+ // The parsed response headers. Owned by the caller of SendRequest.
HttpResponseInfo* response_;
// Indicates the content length. If this value is less than zero

Powered by Google App Engine
This is Rietveld 408576698