HttpStreamParser: Don't reuse sockets which receive unparsed data.

net/http/http_basic_stream.cc

Index: net/http/http_basic_stream.cc
diff --git a/net/http/http_basic_stream.cc b/net/http/http_basic_stream.cc
index 0dd7a9e1dcdd4d020451eab45e2faed6a0ccdbde..c6e0573d8d3601bae6642722820504deecbf9ca4 100644
--- a/net/http/http_basic_stream.cc
+++ b/net/http/http_basic_stream.cc
@@ -7,6 +7,7 @@
 #include "base/memory/scoped_ptr.h"
 #include "net/http/http_request_info.h"
 #include "net/http/http_response_body_drainer.h"
+#include "net/http/http_response_info.h"
 #include "net/http/http_stream_parser.h"
 #include "net/socket/client_socket_handle.h"
 
@@ -116,8 +117,10 @@ Error HttpBasicStream::GetSignedEKMForTokenBinding(crypto::ECPrivateKey* key,
   return parser()->GetSignedEKMForTokenBinding(key, out);
 }
 
-void HttpBasicStream::Drain(HttpNetworkSession* session) {
-  HttpResponseBodyDrainer* drainer = new HttpResponseBodyDrainer(this);
+void HttpBasicStream::Drain(HttpNetworkSession* session,
+                            scoped_ptr<HttpResponseInfo> response_info) {
+  HttpResponseBodyDrainer* drainer =
+      new HttpResponseBodyDrainer(this, std::move(response_info));

[asanka, 2016/05/13 15:19:52]

The ownership semantics of the Drain() method are a bit surprising. Would it be
possible to raise HttpResonseBodyDrainer up so that HttpNetworkTransaction
itself creates it? That way we can explicitly pass down the HttpStream and
HttpResponseInfo via unique_ptrs and make it explicit that both of those objects
are now owned by the HttpResponseBodyDrainer. Thus the latter would be
responsible for asserting that |response_info| outlives |session|.

[mmenke, 2016/05/20 21:50:02]

On one hand, you're right about these ownership semantics...On the other hand,
I'd really like to make it so HttpNetworkTransaction doesn't even know about
draining responses (Draining is HTTP/1.x-specific silliness, and makes no sense
for QUIC/SPDY, so doesn't seem like it should be in the common code shared by
all paths).

Anyhow, I've gone with a different solution, so I'm leaving this as it was
before this CL.

   drainer->Start(session);
   // |drainer| will delete itself.
 }