net/http/http_response_body_drainer.cc - Issue 1884943003: HttpStreamParser: Don't reuse sockets which receive unparsed data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_response_body_drainer.cc

Issue 1884943003: HttpStreamParser: Don't reuse sockets which receive unparsed data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: oops Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_response_body_drainer.cc

diff --git a/net/http/http_response_body_drainer.cc b/net/http/http_response_body_drainer.cc

index fdcec3115d3fc515723f977c54bf68cfd9b4f8f8..6b04f6eca376da6a9486169d85b7135bdafa3c73 100644

--- a/net/http/http_response_body_drainer.cc

+++ b/net/http/http_response_body_drainer.cc

@@ -113,7 +113,7 @@ void HttpResponseBodyDrainer::Finish(int result) {

if (session_)

session_->RemoveResponseDrainer(this);

- if (result < 0) {

+ if (result < 0 || !stream_->CanReuseConnection()) {

stream_->Close(true /* no keep-alive */);

} else {

DCHECK_EQ(OK, result);

« no previous file with comments | « net/http/http_network_transaction_unittest.cc ('k') | net/http/http_response_body_drainer_unittest.cc » ('j') | no next file with comments »