HttpStreamParser: Don't reuse sockets which receive unparsed data.

net/http/http_response_body_drainer_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_response_body_drainer.h"
 
 #include <stdint.h>
 
 #include <cstring>
 
@@ skipping 61 matching lines @@
  public:
   MockHttpStream(CloseResultWaiter* result_waiter)
       : result_waiter_(result_waiter),
         buf_len_(0),
         closed_(false),
         stall_reads_forever_(false),
         num_chunks_(0),
         is_sync_(false),
         is_last_chunk_zero_size_(false),
         is_complete_(false),
+        can_reuse_connection_(true),
         weak_factory_(this) {}
   ~MockHttpStream() override {}
 
   // HttpStream implementation.
   int InitializeStream(const HttpRequestInfo* request_info,
                        RequestPriority priority,
                        const BoundNetLog& net_log,
                        const CompletionCallback& callback) override {
     return ERR_UNEXPECTED;
   }
   int SendRequest(const HttpRequestHeaders& request_headers,
                   HttpResponseInfo* response,
                   const CompletionCallback& callback) override {
     return ERR_UNEXPECTED;
   }
   UploadProgress GetUploadProgress() const override { return UploadProgress(); }
   int ReadResponseHeaders(const CompletionCallback& callback) override {
     return ERR_UNEXPECTED;
   }
 
   bool IsConnectionReused() const override { return false; }
   void SetConnectionReused() override {}
-  bool CanReuseConnection() const override { return false; }
+  bool CanReuseConnection() const override { return can_reuse_connection_; }
   int64_t GetTotalReceivedBytes() const override { return 0; }
   int64_t GetTotalSentBytes() const override { return 0; }
   void GetSSLInfo(SSLInfo* ssl_info) override {}
   void GetSSLCertRequestInfo(SSLCertRequestInfo* cert_request_info) override {}
   bool GetRemoteEndpoint(IPEndPoint* endpoint) override { return false; }
   Error GetSignedEKMForTokenBinding(crypto::ECPrivateKey* key,
                                     std::vector<uint8_t>* out) override {
     ADD_FAILURE();
     return ERR_NOT_IMPLEMENTED;
   }
@@ skipping 24 matching lines @@
 
   // Methods to tweak/observer mock behavior:
   void set_stall_reads_forever() { stall_reads_forever_ = true; }
 
   void set_num_chunks(int num_chunks) { num_chunks_ = num_chunks; }
 
   void set_sync() { is_sync_ = true; }
 
   void set_is_last_chunk_zero_size() { is_last_chunk_zero_size_ = true; }
 
+  // Sets result value of CanReuseConnection. Defaults to true.
+  void set_can_reuse_connection(bool can_reuse_connection) {
+    can_reuse_connection_ = can_reuse_connection;
+  }
+
  private:
   int ReadResponseBodyImpl(IOBuffer* buf, int buf_len);
   void CompleteRead();
 
   bool closed() const { return closed_; }
 
   CloseResultWaiter* const result_waiter_;
   scoped_refptr<IOBuffer> user_buf_;
   CompletionCallback callback_;
   int buf_len_;
   bool closed_;
   bool stall_reads_forever_;
   int num_chunks_;
   bool is_sync_;
   bool is_last_chunk_zero_size_;
   bool is_complete_;
+  bool can_reuse_connection_;
+
   base::WeakPtrFactory<MockHttpStream> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(MockHttpStream);
 };
 
 int MockHttpStream::ReadResponseBody(IOBuffer* buf,
                                      int buf_len,
                                      const CompletionCallback& callback) {
   CHECK(!callback.is_null());
   CHECK(callback_.is_null());
   CHECK(buf);
 
   if (stall_reads_forever_)
@@ skipping 132 matching lines @@
 TEST_F(HttpResponseBodyDrainerTest, DrainBodyTooLarge) {
   int too_many_chunks =
       HttpResponseBodyDrainer::kDrainBodyBufferSize / kMagicChunkSize;
   too_many_chunks += 1;  // Now it's too large.
 
   mock_stream_->set_num_chunks(too_many_chunks);
   drainer_->Start(session_.get());
   EXPECT_TRUE(result_waiter_.WaitForResult());
 }
 
+TEST_F(HttpResponseBodyDrainerTest, DrainBodyCantReuse) {
+  mock_stream_->set_num_chunks(1);
+  mock_stream_->set_can_reuse_connection(false);
+  drainer_->Start(session_.get());
+  EXPECT_TRUE(result_waiter_.WaitForResult());
+}
+
 }  // namespace
 
 }  // namespace net