Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1884943002: Add some new stream types to MDStreamType (Closed)

Created:
4 years, 8 months ago by Ted Mielczarek
Modified:
4 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add some new stream types to MDStreamType I ran minidump_dump on a dump from Firefox on my Windows 10 machine and noticed some streams that Breakpad didn't have names for. Looking in minidumpapiset.h in the Windows 10 SDK finds these values in MINIDUMP_STREAM_TYPE. There are also struct definitions for the stream data for some of them (all but JavaScriptData), but I don't have a particular need for those currently. R=mark@chromium.org BUG= Committed: https://chromium.googlesource.com/breakpad/breakpad/+/fee47f4638072e9b049ffa745bbb8aa5be986698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/google_breakpad/common/minidump_format.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/processor/minidump.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Ted Mielczarek
4 years, 8 months ago (2016-04-13 10:51:55 UTC) #1
Mark Mentovai
LGTM
4 years, 8 months ago (2016-04-13 15:35:41 UTC) #2
Ted Mielczarek
4 years, 8 months ago (2016-04-13 16:15:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fee47f4638072e9b049ffa745bbb8aa5be986698 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698