Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1884913002: Update V8 to version 5.2.20. (Closed)

Created:
4 years, 8 months ago by v8-autoroll
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update V8 to version 5.2.20. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f7a11412..d8d54ea9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Committed: https://crrev.com/31e492eab1deee4798c016ed4d7b306997f4dd82 Cr-Commit-Position: refs/heads/master@{#386958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
v8-autoroll
4 years, 8 months ago (2016-04-13 07:32:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884913002/1
4 years, 8 months ago (2016-04-13 07:32:31 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/52897)
4 years, 8 months ago (2016-04-13 08:50:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884913002/1
4 years, 8 months ago (2016-04-13 09:00:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 10:15:44 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/31e492eab1deee4798c016ed4d7b306997f4dd82 Cr-Commit-Position: refs/heads/master@{#386958}
4 years, 8 months ago (2016-04-13 10:17:37 UTC) #10
Nico
4 years, 8 months ago (2016-04-13 11:43:26 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1877403004/ by thakis@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/chromium.fyi/builders/WinClang/builds/205/steps/...

../../v8/src/runtime/runtime-atomics.cc(126,1):  error: unused function
'LoadSeqCst' [-Werror,-Wunused-function]
ATOMIC_OPS(int8_t, 8, char)
^
../../v8/src/runtime/runtime-atomics.cc(120,15):  note: expanded from macro
'ATOMIC_OPS'
  inline type LoadSeqCst(type* p) { return *p; }                            \
              ^.

Powered by Google App Engine
This is Rietveld 408576698