Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: content/browser/renderer_host/input/synthetic_gesture_target_base.cc

Issue 1884883005: Prepare SyntheticPointerAction to handle touch actions for multiple fingers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move logic to controller Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/synthetic_gesture_target_base.cc
diff --git a/content/browser/renderer_host/input/synthetic_gesture_target_base.cc b/content/browser/renderer_host/input/synthetic_gesture_target_base.cc
index e1fd3b06f3136572db2eb024dcee478faa9f961e..5b54e1adbd9e4175e4ff461170c7005e4b5ca71d 100644
--- a/content/browser/renderer_host/input/synthetic_gesture_target_base.cc
+++ b/content/browser/renderer_host/input/synthetic_gesture_target_base.cc
@@ -55,13 +55,11 @@ void SyntheticGestureTargetBase::DispatchInputEventToPlatform(
static_cast<const WebTouchEvent&>(event);
// Check that all touch pointers are within the content bounds.
- if (web_touch.type == WebInputEvent::TouchStart) {
- for (unsigned i = 0; i < web_touch.touchesLength; i++)
- CHECK(web_touch.touches[i].state != WebTouchPoint::StatePressed ||
- PointIsWithinContents(web_touch.touches[i].position.x,
- web_touch.touches[i].position.y))
- << "Touch coordinates are not within content bounds on TouchStart.";
- }
+ for (unsigned i = 0; i < web_touch.touchesLength; i++)
+ CHECK(web_touch.touches[i].state != WebTouchPoint::StatePressed ||
+ PointIsWithinContents(web_touch.touches[i].position.x,
+ web_touch.touches[i].position.y))
+ << "Touch coordinates are not within content bounds on TouchStart.";
tdresser 2016/05/13 13:58:04 Is dragging your finger outside the window reasona
lanwei 2016/05/19 16:04:13 Because when we combine actions together, sometime
DispatchWebTouchEventToPlatform(web_touch, latency_info);
} else if (event.type == WebInputEvent::MouseWheel) {

Powered by Google App Engine
This is Rietveld 408576698