Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1884883003: Revert of [Atomics] code stubs for atomic operations (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, JF, danno
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Atomics] code stubs for atomic operations (patchset #28 id:530001 of https://codereview.chromium.org/1617503003/ ) Reason for revert: [Sheriff] Roll was reverted. Please fix unused methods, see: https://codereview.chromium.org/1884913002/ https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/5585/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > [Atomics] code stubs for atomic operations > > * New atomic code stubs for x64, ia32, arm, arm64 > * Add convenience functions JumpIfNotValidSmiValue, JumpIfUintNotValidSmiValue > to macro-assembler-ia32 (API based on x64 macro assembler) > * Remove runtime implementation of Atomics.load, the code stub should always be > called instead > * Add new test to mjsunit atomics test; check that Smi values of different > sizes are supported when possible, else fall back to HeapNumbers > > These changes were needed to add another codestub: > * Bump kStubMajorKeyBits from 7 to 8 > * Reduce ScriptContextFieldStub::kSlotIndexBits from 13 to 12 > > BUG=v8:4614 > LOG=y > > Committed: https://crrev.com/10b5febe11b318cfef130abae343183ac862e60d > Cr-Commit-Position: refs/heads/master@{#35427} TBR=jarin@chromium.org,bmeurer@chromium.org,rodolph.perfetta@gmail.com,binji@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4614 Committed: https://crrev.com/2a5cce658009644c0326a16df81bd30a0809f2c7 Cr-Commit-Position: refs/heads/master@{#35443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -983 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -160 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -138 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/builtins.h View 2 chunks +13 lines, -16 lines 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -137 lines 0 comments Download
M src/code-factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/code-factory.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/code-stubs.h View 3 chunks +1 line, -10 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -169 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -17 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +1 line, -7 lines 0 comments Download
M src/js/harmony-atomics.js View 3 chunks +13 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +11 lines, -13 lines 0 comments Download
M src/runtime/runtime-atomics.cc View 3 chunks +32 lines, -23 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -163 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M test/mjsunit/harmony/atomics.js View 4 chunks +18 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [Atomics] code stubs for atomic operations
4 years, 8 months ago (2016-04-13 11:58:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884883003/1
4 years, 8 months ago (2016-04-13 11:58:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 11:58:34 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 11:59:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a5cce658009644c0326a16df81bd30a0809f2c7
Cr-Commit-Position: refs/heads/master@{#35443}

Powered by Google App Engine
This is Rietveld 408576698