Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1884873007: X87: [Interpreter] Changes GenerateDoubleToObject to push and pop rsi value. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Changes GenerateDoubleToObject to push and pop rsi value. port e6b6e5545386985f1d0bec875307e5df52062d71 (r35163) original commit message: In the earlier implementation of GenerateDoubleToObject the context is loaded from the parent's frame. rsi is clobbered because it is used to store kHoleNan constnat. It is not always safe to peek at the parents frame. Bytecode handlers have TypedFrame and the type of frame is stored at FP + 1. GenerateDoubleToObject expects context to be store at that place. In the current implementation rsi is pushed onto the stack and is popped when exiting this function. BUG= Committed: https://crrev.com/a0d2f240c3efdb4c56bbdee4fc4cb40c1015b3d8 Cr-Commit-Position: refs/heads/master@{#35478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/x87/codegen-x87.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-14 07:43:08 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-14 08:23:40 UTC) #3
mythria
lgtm. Thanks, Mythri
4 years, 8 months ago (2016-04-14 08:57:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884873007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884873007/1
4 years, 8 months ago (2016-04-14 09:07:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 09:28:09 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 09:28:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0d2f240c3efdb4c56bbdee4fc4cb40c1015b3d8
Cr-Commit-Position: refs/heads/master@{#35478}

Powered by Google App Engine
This is Rietveld 408576698