Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1884873004: Revert of ⛄ Capture Android stderr when symbolizing native stack traces. (Closed)

Created:
4 years, 8 months ago by Tima Vaisburd
Modified:
4 years, 8 months ago
Reviewers:
Yaron, rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ⛄ Capture Android stderr when symbolizing native stack traces. (patchset #1 id:1 of https://codereview.chromium.org/1886473002/ ) Reason for revert: Seems to cause exception failures on the bots: NameError: global name 'java_exceptions' is not defined E.g. https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20WebView%20CTS%20L-MR1%20%28dbg%29/builds/9749 What is |java_exceptions| at the end of stack_core.py? Original issue's description: > Capture Android stderr when symbolizing native stack traces. > > When native->Java results in a Java exception, upon the stack returning > back to C++, we dump the Java exception to stderr and then signal a crash. > > Update our stack tool to capture Java-formatted stderr while processing logcat and dump > all matching logs if the pid of the error matches the native stack. > While this may sometimes be irrelevant, it can often include the Java > exception and makes it easier to triage and less confusing. > > BUG=602651 > > Committed: https://crrev.com/e35a5d8d7063a1feb552a3d517f600a071277285 > Cr-Commit-Position: refs/heads/master@{#386987} TBR=rmcilroy@chromium.org,yfriedman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=602651 Committed: https://crrev.com/fa0d5241405e4dadb49b93b49ce40685c1406fad Cr-Commit-Position: refs/heads/master@{#387015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -44 lines) Patch
M third_party/android_platform/README.chromium View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/android_platform/development/scripts/stack_core.py View 10 chunks +5 lines, -43 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tima Vaisburd
Created Revert of ⛄ Capture Android stderr when symbolizing native stack traces.
4 years, 8 months ago (2016-04-13 17:22:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884873004/1
4 years, 8 months ago (2016-04-13 17:22:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 17:23:07 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 17:24:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa0d5241405e4dadb49b93b49ce40685c1406fad
Cr-Commit-Position: refs/heads/master@{#387015}

Powered by Google App Engine
This is Rietveld 408576698