Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: ui/events/blink/input_handler_proxy_unittest.cc

Issue 1884863003: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove API from ChromeClient Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/blink/input_handler_proxy.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/blink/input_handler_proxy_unittest.cc
diff --git a/ui/events/blink/input_handler_proxy_unittest.cc b/ui/events/blink/input_handler_proxy_unittest.cc
index 729029b4b1d6273c22ed12e9f5805e73cc4a5236..51f3be226ab7c463c7abc525ccbd298ea7d662fb 100644
--- a/ui/events/blink/input_handler_proxy_unittest.cc
+++ b/ui/events/blink/input_handler_proxy_unittest.cc
@@ -1991,8 +1991,13 @@ TEST_P(InputHandlerProxyTest, MultiTouchPointHitTestNegative) {
expected_disposition_ = InputHandlerProxy::DROP_EVENT;
VERIFY_AND_RESET_MOCKS();
- EXPECT_CALL(mock_input_handler_,
- GetEventListenerProperties(cc::EventListenerClass::kTouch))
+ EXPECT_CALL(
+ mock_input_handler_,
+ GetEventListenerProperties(cc::EventListenerClass::kTouchStartOrMove))
+ .WillOnce(testing::Return(cc::EventListenerProperties::kNone));
+ EXPECT_CALL(
+ mock_input_handler_,
+ GetEventListenerProperties(cc::EventListenerClass::kTouchEndOrCancel))
.WillOnce(testing::Return(cc::EventListenerProperties::kNone));
EXPECT_CALL(mock_input_handler_, DoTouchEventsBlockScrollAt(testing::_))
.WillOnce(testing::Return(false));
@@ -2048,8 +2053,9 @@ TEST_P(InputHandlerProxyTest, MultiTouchPointHitTestPassivePositive) {
expected_disposition_ = InputHandlerProxy::DID_HANDLE_NON_BLOCKING;
VERIFY_AND_RESET_MOCKS();
- EXPECT_CALL(mock_input_handler_,
- GetEventListenerProperties(cc::EventListenerClass::kTouch))
+ EXPECT_CALL(
+ mock_input_handler_,
+ GetEventListenerProperties(cc::EventListenerClass::kTouchStartOrMove))
.WillRepeatedly(testing::Return(cc::EventListenerProperties::kPassive));
EXPECT_CALL(mock_input_handler_, DoTouchEventsBlockScrollAt(testing::_))
.WillRepeatedly(testing::Return(false));
@@ -2066,6 +2072,38 @@ TEST_P(InputHandlerProxyTest, MultiTouchPointHitTestPassivePositive) {
VERIFY_AND_RESET_MOCKS();
}
+TEST_P(InputHandlerProxyTest, TouchStartPassiveAndTouchEndBlocking) {
+ // The touch start is not in a touch-region but there is a touch end handler
+ // so to maintain targeting we need to dispatch the touch start as
+ // non-blocking but drop all touch moves.
+ expected_disposition_ = InputHandlerProxy::DID_HANDLE_NON_BLOCKING;
+ VERIFY_AND_RESET_MOCKS();
+
+ EXPECT_CALL(
+ mock_input_handler_,
+ GetEventListenerProperties(cc::EventListenerClass::kTouchStartOrMove))
+ .WillOnce(testing::Return(cc::EventListenerProperties::kNone));
+ EXPECT_CALL(
+ mock_input_handler_,
+ GetEventListenerProperties(cc::EventListenerClass::kTouchEndOrCancel))
+ .WillOnce(testing::Return(cc::EventListenerProperties::kBlocking));
+ EXPECT_CALL(mock_input_handler_, DoTouchEventsBlockScrollAt(testing::_))
+ .WillOnce(testing::Return(false));
+
+ WebTouchEvent touch;
+ touch.type = WebInputEvent::TouchStart;
+ touch.touchesLength = 1;
+ touch.touches[0] = CreateWebTouchPoint(WebTouchPoint::StatePressed, 0, 0);
+ EXPECT_EQ(expected_disposition_, input_handler_->HandleInputEvent(touch));
+
+ touch.type = WebInputEvent::TouchMove;
+ touch.touchesLength = 1;
+ touch.touches[0] = CreateWebTouchPoint(WebTouchPoint::StatePressed, 10, 10);
+ EXPECT_EQ(InputHandlerProxy::DROP_EVENT,
+ input_handler_->HandleInputEvent(touch));
+ VERIFY_AND_RESET_MOCKS();
+}
+
TEST_P(InputHandlerProxyTest, GestureFlingCancelledByKeyboardEvent) {
// We shouldn't send any events to the widget for this gesture.
expected_disposition_ = InputHandlerProxy::DID_HANDLE;
« no previous file with comments | « ui/events/blink/input_handler_proxy.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698