Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 1884863003: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
index 61a0bfa6c2d66e97cabf465c0b10f3c09a409a8f..2d2c7007c069f6b42fa8b5e6e0f911cf37f12bd4 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
@@ -163,10 +163,13 @@ private:
m_popup->m_webView->client()->didChangeCursor(WebCursorInfo(cursor));
}
+ void setHasTouchEventListeners(bool hasListeners) override
+ {
+ m_popup->widgetClient()->hasTouchEventHandlers(hasListeners);
+ }
+
void setEventListenerProperties(WebEventListenerClass eventClass, WebEventListenerProperties properties) override
{
- if (eventClass == WebEventListenerClass::Touch)
- m_popup->widgetClient()->hasTouchEventHandlers(properties != WebEventListenerProperties::Nothing);
if (m_popup->m_layerTreeView)
m_popup->m_layerTreeView->setEventListenerProperties(eventClass, properties);
}
@@ -177,13 +180,13 @@ private:
return WebEventListenerProperties::Nothing;
}
- void setHaveScrollEventHandlers(bool hasEventHandlers) override
+ void setHasScrollEventHandlers(bool hasEventHandlers) override
{
if (m_popup->m_layerTreeView)
m_popup->m_layerTreeView->setHaveScrollEventHandlers(hasEventHandlers);
}
- bool haveScrollEventHandlers() const override
+ bool hasScrollEventHandlers() const override
{
if (m_popup->m_layerTreeView)
return m_popup->m_layerTreeView->haveScrollEventHandlers();

Powered by Google App Engine
This is Rietveld 408576698