third_party/WebKit/Source/core/input/EventHandler.cpp - Issue 1884863003: Non passive touch end or touch cancel listeners should not block scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 1884863003: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp ('K') | « third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp ('k') | third_party/WebKit/Source/core/loader/EmptyClients.h » ('j') | third_party/WebKit/Source/core/testing/Internals.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/input/EventHandler.cpp

diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp

index e54b78d72edbaf4f11f619e3a84ca813e6dae23e..e9e2e40d054fd7edeea2f95417c9a26c378eb5e9 100644

--- a/third_party/WebKit/Source/core/input/EventHandler.cpp

+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp

@@ -110,7 +110,9 @@ namespace {

bool hasTouchHandlers(const EventHandlerRegistry& registry)

{

return registry.hasEventHandlers(EventHandlerRegistry::TouchEventBlocking)

- || registry.hasEventHandlers(EventHandlerRegistry::TouchEventPassive);

+ || registry.hasEventHandlers(EventHandlerRegistry::TouchEventPassive)

+ || registry.hasEventHandlers(EventHandlerRegistry::TouchEndOrCancelEventBlocking)

+ || registry.hasEventHandlers(EventHandlerRegistry::TouchEndOrCancelEventPassive);

}

const AtomicString& touchEventNameForTouchPointState(PlatformTouchPoint::TouchState state)