Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Unified Diff: third_party/WebKit/Source/core/frame/EventHandlerRegistry.h

Issue 1884863003: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/EventHandlerRegistry.h
diff --git a/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h b/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h
index 4d1dd0882a33c5f0aa9ee129ac6a517517c0a885..f9d273d7a9d8ec2825cb12718b10674be7da9cf8 100644
--- a/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h
+++ b/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h
@@ -33,6 +33,8 @@ public:
WheelEventPassive,
TouchEventBlocking,
TouchEventPassive,
Rick Byers 2016/04/14 01:41:41 Please rename these to TouchStartOrMove* for symme
dtapuska 2016/04/14 01:49:10 Do you want the WebEventListenerClass enum renamed
dtapuska 2016/04/14 14:41:11 Done.
+ TouchEndOrCancelEventBlocking,
+ TouchEndOrCancelEventPassive,
#if ENABLE(ASSERT)
// Additional event categories for verifying handler tracking logic.
EventsForTesting,
@@ -80,6 +82,9 @@ private:
// removed an existing one.
bool updateEventHandlerTargets(ChangeOperation, EventHandlerClass, EventTarget*);
+ // Update whether we have any touch handler or not.
+ void updateHasTouchEventListeners();
+
// Called on the EventHandlerRegistry of the root Document to notify
// clients when we have added the first handler or removed the last one for
// a given event class. |hasActiveHandlers| can be used to distinguish

Powered by Google App Engine
This is Rietveld 408576698