third_party/WebKit/Source/web/WebPagePopupImpl.cpp - Issue 1884863003: Non passive touch end or touch cancel listeners should not block scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 1884863003: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/ChromeClientImpl.h ('K') | « third_party/WebKit/Source/web/ChromeClientImpl.cpp ('k') | third_party/WebKit/public/platform/WebEventListenerProperties.h » ('j') | ui/events/blink/input_handler_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

index 61a0bfa6c2d66e97cabf465c0b10f3c09a409a8f..12c16f7968948ebeabbe254c436a0669ecf91b3d 100644

--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

@@ -163,10 +163,13 @@ private:

m_popup->m_webView->client()->didChangeCursor(WebCursorInfo(cursor));

}

+ void setHaveTouchEventListeners(bool hasListeners) override

+ {

+ m_popup->widgetClient()->hasTouchEventHandlers(hasListeners);

+ }

void setEventListenerProperties(WebEventListenerClass eventClass, WebEventListenerProperties properties) override

{

- if (eventClass == WebEventListenerClass::Touch)

- m_popup->widgetClient()->hasTouchEventHandlers(properties != WebEventListenerProperties::Nothing);

if (m_popup->m_layerTreeView)

m_popup->m_layerTreeView->setEventListenerProperties(eventClass, properties);

}