Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 1884863003: Non passive touch end or touch cancel listeners should not block scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove API from ChromeClient Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 405 matching lines...) Expand 10 before | Expand all | Expand 10 after
416 ASSERT(m_inputTypeView); 416 ASSERT(m_inputTypeView);
417 417
418 bool hasTouchEventHandler = m_inputTypeView->hasTouchEventHandler(); 418 bool hasTouchEventHandler = m_inputTypeView->hasTouchEventHandler();
419 if (hasTouchEventHandler == !!m_hasTouchEventHandler) 419 if (hasTouchEventHandler == !!m_hasTouchEventHandler)
420 return; 420 return;
421 // If the Document is being or has been stopped, don't register any handlers . 421 // If the Document is being or has been stopped, don't register any handlers .
422 if (document().frameHost() && document().lifecycle().state() < DocumentLifec ycle::Stopping) { 422 if (document().frameHost() && document().lifecycle().state() < DocumentLifec ycle::Stopping) {
423 EventHandlerRegistry& registry = document().frameHost()->eventHandlerReg istry(); 423 EventHandlerRegistry& registry = document().frameHost()->eventHandlerReg istry();
424 // TODO(dtapuska): Make this passive touch listener see crbug.com/584438 424 // TODO(dtapuska): Make this passive touch listener see crbug.com/584438
425 if (hasTouchEventHandler) 425 if (hasTouchEventHandler)
426 registry.didAddEventHandler(*this, EventHandlerRegistry::TouchEventB locking); 426 registry.didAddEventHandler(*this, EventHandlerRegistry::TouchStartO rMoveEventBlocking);
427 else 427 else
428 registry.didRemoveEventHandler(*this, EventHandlerRegistry::TouchEve ntBlocking); 428 registry.didRemoveEventHandler(*this, EventHandlerRegistry::TouchSta rtOrMoveEventBlocking);
429 m_hasTouchEventHandler = hasTouchEventHandler; 429 m_hasTouchEventHandler = hasTouchEventHandler;
430 } 430 }
431 } 431 }
432 432
433 void HTMLInputElement::initializeTypeInParsing() 433 void HTMLInputElement::initializeTypeInParsing()
434 { 434 {
435 ASSERT(m_parsingInProgress); 435 ASSERT(m_parsingInProgress);
436 ASSERT(!m_inputType); 436 ASSERT(!m_inputType);
437 ASSERT(!m_inputTypeView); 437 ASSERT(!m_inputTypeView);
438 438
(...skipping 1489 matching lines...) Expand 10 before | Expand all | Expand 10 after
1928 void HTMLInputElement::ensurePrimaryContent() 1928 void HTMLInputElement::ensurePrimaryContent()
1929 { 1929 {
1930 m_inputTypeView->ensurePrimaryContent(); 1930 m_inputTypeView->ensurePrimaryContent();
1931 } 1931 }
1932 1932
1933 bool HTMLInputElement::hasFallbackContent() const 1933 bool HTMLInputElement::hasFallbackContent() const
1934 { 1934 {
1935 return m_inputTypeView->hasFallbackContent(); 1935 return m_inputTypeView->hasFallbackContent();
1936 } 1936 }
1937 } // namespace blink 1937 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp ('k') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698