Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1884833002: Mozart: Publish scene when scene token becomes available. (Closed)

Created:
4 years, 8 months ago by jeffbrown
Modified:
4 years, 8 months ago
Reviewers:
anwilson, abarth
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mozart: Publish scene when scene token becomes available. Fixes a bug in the Mozart view manager where the stub scene (the wrapper) was only updated when the view token became available or when view properties changed. We forgot to also do it when the stub scene token becomes available. We didn't notice this problem before because normally we hit the case where the view token gets resolved after the scene token but if the view already exists then we may end up in the case where the long pole is waiting for the scene to be registered. BUG= R=anwilson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/b98c4fe8e3f25f51813da78db01825cd629d218e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M services/ui/view_manager/view_registry.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jeffbrown
Yup, it was a dumb bug.
4 years, 8 months ago (2016-04-12 23:57:24 UTC) #2
anwilson
On 2016/04/12 23:57:24, jeffbrown wrote: > Yup, it was a dumb bug. lgtm!
4 years, 8 months ago (2016-04-13 00:00:29 UTC) #3
anwilson
lgtm
4 years, 8 months ago (2016-04-13 00:00:36 UTC) #4
anwilson
lgtm
4 years, 8 months ago (2016-04-13 00:00:37 UTC) #5
jeffbrown
4 years, 8 months ago (2016-04-13 00:03:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b98c4fe8e3f25f51813da78db01825cd629d218e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698