Issue 188483002: ia32: Simplify inlined Smi code for SAR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 188483002: ia32: Simplify inlined Smi code for SAR. (Closed)

Created:
6 years, 9 months ago by Benedikt Meurer

Modified:
6 years, 9 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/ia32/full-codegen-ia32.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Sven Panne

LGTM, but can't we do something similar on x64? SmiShiftArithmeticRight seems to be total overkill ...

6 years, 9 months ago (2014-03-06 08:24:24 UTC) #2

Benedikt Meurer

On 2014/03/06 08:24:24, Sven Panne wrote: > LGTM, but can't we do something similar on ...

6 years, 9 months ago (2014-03-06 08:25:52 UTC) #3

Benedikt Meurer

6 years, 9 months ago (2014-03-07 08:36:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19700 (presubmit successful).