Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: pkg/compiler/lib/src/library_loader.dart

Issue 1884793002: dart2js: remove references to compiler in ResolvedUriTranslator (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/library_loader.dart
diff --git a/pkg/compiler/lib/src/library_loader.dart b/pkg/compiler/lib/src/library_loader.dart
index b666bfa8955f2de879f4fe1cfb56b2226e4c1d5c..5793aa425829a855f6c1ed29ddd432d639e225e6 100644
--- a/pkg/compiler/lib/src/library_loader.dart
+++ b/pkg/compiler/lib/src/library_loader.dart
@@ -6,9 +6,9 @@ library dart2js.library_loader;
import 'dart:async';
-import 'common.dart';
import 'common/names.dart' show Uris;
import 'common/tasks.dart' show CompilerTask;
+import 'common.dart';
import 'compiler.dart' show Compiler;
import 'elements/elements.dart'
show
@@ -16,8 +16,7 @@ import 'elements/elements.dart'
Element,
ImportElement,
ExportElement,
- LibraryElement,
- PrefixElement;
+ LibraryElement;
import 'elements/modelx.dart'
show
CompilationUnitElementX,
@@ -30,6 +29,7 @@ import 'elements/modelx.dart'
PrefixElementX,
SyntheticImportElement;
import 'environment.dart';
+import 'resolved_uri_translator.dart';
import 'script.dart';
import 'serialization/serialization.dart' show LibraryDeserializer;
import 'tree/tree.dart';
@@ -1405,17 +1405,6 @@ class _LoadedLibraries implements LoadedLibraries {
String toString() => 'root=$rootLibrary,libraries=${loadedLibraries.keys}';
}
-/// API used by the library loader to translate internal SDK URIs into file
-/// system readable URIs.
-abstract class ResolvedUriTranslator {
- // TODO(sigmund): move here the comments from library loader.
- /// Translate the resolved [uri] in the context of [importingLibrary].
- ///
- /// Use [spannable] for error reporting.
- Uri translate(LibraryElement importingLibrary, Uri uri,
- [Spannable spannable]);
-}
-
// TODO(sigmund): remove ScriptLoader & ElementScanner. Such abstraction seems
// rather low-level. It might be more practical to split the library-loading
// task itself. The task would continue to do the work of recursively loading

Powered by Google App Engine
This is Rietveld 408576698