Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1884773002: Fix the code which causes Windows GN build warning (Closed)

Created:
4 years, 8 months ago by Wei Li
Modified:
4 years, 8 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix the code which causes Windows GN build warning The signed/unsigned comparison is causing the chromium windows GN build broken. Committed: https://pdfium.googlesource.com/pdfium/+/461129efe889fa7d653c8c4620a12179eeddd5ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M core/fxge/ge/fx_ge_fontmap.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Wei Li
PTAL, thanks. @ochang, We should be able to roll after this while I am looking ...
4 years, 8 months ago (2016-04-12 20:55:38 UTC) #2
Oliver Chang
On 2016/04/12 20:55:38, Wei Li wrote: > PTAL, thanks. > @ochang, We should be able ...
4 years, 8 months ago (2016-04-12 20:59:30 UTC) #3
Oliver Chang
+Tom in case Dan already left for the day.
4 years, 8 months ago (2016-04-12 21:02:20 UTC) #7
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-12 21:06:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884773002/1
4 years, 8 months ago (2016-04-12 21:08:50 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 21:47:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/461129efe889fa7d653c8c4620a12179eedd...

Powered by Google App Engine
This is Rietveld 408576698