Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1399)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1884733002: Remove SimpleOffsetFilter (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SimpleOffsetFilter SimpleOffsetFilter & SkOffsetImageFilter seem equivalent nowadays. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1884733002 Committed: https://skia.googlesource.com/skia/+/134ff5c9cf99e1a930cb1b77bf8fb2b7b2c31d31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -89 lines) Patch
M gm/imagefiltersgraph.cpp View 3 chunks +3 lines, -89 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 8 months ago (2016-04-12 18:38:50 UTC) #4
Stephen White
LGTM
4 years, 8 months ago (2016-04-12 19:06:55 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884733002/1
4 years, 8 months ago (2016-04-12 19:25:05 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-12 19:37:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884733002/1
4 years, 8 months ago (2016-04-12 19:40:06 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 19:41:03 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/134ff5c9cf99e1a930cb1b77bf8fb2b7b2c31d31

Powered by Google App Engine
This is Rietveld 408576698