src/compiler/representation-change.cc - Issue 1884713003: [turbofan] Change number operations to handle Undefined as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/representation-change.cc

Issue 1884713003: [turbofan] Change number operations to handle Undefined as well. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove TODOs for realz now Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/representation-change.cc

diff --git a/src/compiler/representation-change.cc b/src/compiler/representation-change.cc

index fedf7afc0e96dc4fb79760d7b4150104b7a8e676..5744de1d54c0028785fb353eb0e2165d069c58ff 100644

--- a/src/compiler/representation-change.cc

+++ b/src/compiler/representation-change.cc

@@ -253,7 +253,7 @@ Node* RepresentationChanger::GetFloat32RepresentationFor(

op = machine()->TruncateFloat64ToFloat32();

}

} else if (output_rep == MachineRepresentation::kTagged) {

- if (output_type->Is(Type::Number())) {

+ if (output_type->Is(Type::NumberOrUndefined())) {

op = simplified()

->ChangeTaggedToFloat64(); // tagged -> float64 -> float32

node = jsgraph()->graph()->NewNode(op, node);

@@ -305,7 +305,7 @@ Node* RepresentationChanger::GetFloat64RepresentationFor(

op = machine()->ChangeUint32ToFloat64();

}

} else if (output_rep == MachineRepresentation::kTagged) {

- if (output_type->Is(Type::Number())) {

+ if (output_type->Is(Type::NumberOrUndefined())) {

op = simplified()->ChangeTaggedToFloat64();

}

} else if (output_rep == MachineRepresentation::kFloat32) {

« no previous file with comments | « src/compiler/representation-change.h ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »