[turbofan] Change number operations to handle Undefined as well.

[turbofan] Change number operations to handle Undefined as well.

This allows us to remove the turbofan bailout that we introduced
as a response to crbug.com/589792.

BUG=chromium:589792
LOG=n

Committed: https://crrev.com/f5961f90b12d457cd5ce327a0a387396e74ee22f
Cr-Commit-Position: refs/heads/master@{#35493}

[Jarin, 2016-04-13 15:20:24]

jarin@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Jarin, 2016-04-13 15:20:25]

Could you take a look, please?

I have not renamed any operators as I do not like the Arith* names either - it
does not suggest that it should operate on undefined any better than the Number*
names.

[Benedikt Meurer, 2016-04-14 04:57:44]

Looks good to me. What is the performance?

https://codereview.chromium.org/1884713003/diff/20001/src/compiler/representa...
File src/compiler/representation-change.h (right):

https://codereview.chromium.org/1884713003/diff/20001/src/compiler/representa...
src/compiler/representation-change.h:34: bool TruncatesToFloat64() const {
I suppose you also need something like TruncatesToFloat32 here, which might be
generally useful.

[Benedikt Meurer, 2016-04-14 05:16:26]

Once this is in and the LoadBuffer hack is gone, we can also do strength
reduction on Number operators, i.e. x|0 => NumberToInt32(x) instead of
NumberBitwiseOr(NumberToInt32(x), #0)

[Jarin, 2016-04-14 12:45:01]

Could you take another look? Performance regressions should be fixed now (+
mandreel has 3x improvement).

[Benedikt Meurer, 2016-04-14 13:10:57]

LGTM

[Jarin, 2016-04-14 13:11:18]

The CQ bit was checked by jarin@chromium.org

[commit-bot: I haz the power, 2016-04-14 13:11:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1884713003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1884713003/120001

[commit-bot: I haz the power, 2016-04-14 13:13:29]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-04-14 13:14:04]

Description was changed from

==========
[turbofan] Change number operations to handle Undefined as well.

This allows us to remove the turbofan bailout that we introduced
as a response to crbug.com/589792.

BUG=chromium:589792
LOG=n
==========

to

==========
[turbofan] Change number operations to handle Undefined as well.

This allows us to remove the turbofan bailout that we introduced
as a response to crbug.com/589792.

BUG=chromium:589792
LOG=n

Committed: https://crrev.com/f5961f90b12d457cd5ce327a0a387396e74ee22f
Cr-Commit-Position: refs/heads/master@{#35493}
==========

[commit-bot: I haz the power, 2016-04-14 13:14:05]

Patchset 7 (id:??) landed as
https://crrev.com/f5961f90b12d457cd5ce327a0a387396e74ee22f
Cr-Commit-Position: refs/heads/master@{#35493}