Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1884713003: [turbofan] Change number operations to handle Undefined as well. (Closed)

Created:
4 years, 8 months ago by Jarin
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Change number operations to handle Undefined as well. This allows us to remove the turbofan bailout that we introduced as a response to crbug.com/589792. BUG=chromium:589792 LOG=n Committed: https://crrev.com/f5961f90b12d457cd5ce327a0a387396e74ee22f Cr-Commit-Position: refs/heads/master@{#35493}

Patch Set 1 #

Patch Set 2 : Tweaks #

Total comments: 1

Patch Set 3 : Fix float32 #

Patch Set 4 : Tweak JSAdd to go through the ToNumber-simplification machinery #

Patch Set 5 : Rebase #

Patch Set 6 : Tweak #

Patch Set 7 : Remove TODOs for realz now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -71 lines) Patch
M src/compiler/change-lowering.cc View 1 2 3 3 chunks +62 lines, -14 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 chunk +7 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 3 4 5 6 10 chunks +17 lines, -14 lines 0 comments Download
M src/compiler/representation-change.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 3 4 12 chunks +33 lines, -29 lines 0 comments Download
M src/compiler/typer.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 3 4 2 chunks +14 lines, -4 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Jarin
Could you take a look, please? I have not renamed any operators as I do ...
4 years, 8 months ago (2016-04-13 15:20:25 UTC) #2
Benedikt Meurer
Looks good to me. What is the performance? https://codereview.chromium.org/1884713003/diff/20001/src/compiler/representation-change.h File src/compiler/representation-change.h (right): https://codereview.chromium.org/1884713003/diff/20001/src/compiler/representation-change.h#newcode34 src/compiler/representation-change.h:34: bool ...
4 years, 8 months ago (2016-04-14 04:57:44 UTC) #3
Benedikt Meurer
Once this is in and the LoadBuffer hack is gone, we can also do strength ...
4 years, 8 months ago (2016-04-14 05:16:26 UTC) #4
Jarin
Could you take another look? Performance regressions should be fixed now (+ mandreel has 3x ...
4 years, 8 months ago (2016-04-14 12:45:01 UTC) #5
Benedikt Meurer
LGTM
4 years, 8 months ago (2016-04-14 13:10:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884713003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884713003/120001
4 years, 8 months ago (2016-04-14 13:11:23 UTC) #8
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 8 months ago (2016-04-14 13:13:29 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 13:14:05 UTC) #11
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/f5961f90b12d457cd5ce327a0a387396e74ee22f
Cr-Commit-Position: refs/heads/master@{#35493}

Powered by Google App Engine
This is Rietveld 408576698