Issue 1884703002: Add SkyShell.app to the Mac artifacts.zip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Created:
4 years, 8 months ago by eseidel

Modified:
4 years, 6 months ago

Reviewers:
abarth, abarth-chromium

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

Add SkyShell.app to the Mac artifacts.zip This should unblock solving https://github.com/flutter/flutter/issues/1707 in the flutter_tools layer. R=abarth@chromium.org

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+343 lines, -61 lines)			Patch
M	scripts/slave/recipes/flutter/engine.py	View	1 2	6 chunks	+18 lines, -6 lines	0 comments	Download
M	scripts/slave/recipes/flutter/engine.expected/linux.json	View	1 2	28 chunks	+312 lines, -42 lines	0 comments	Download
M	scripts/slave/recipes/flutter/engine.expected/mac.json	View	1 2	13 chunks	+13 lines, -13 lines	0 comments	Download

Total messages: 3 (1 generated)

abarth

4 years, 8 months ago (2016-04-12 17:54:39 UTC) #3

I don't think we should both shell out to zip and use api.zip.  We should pick
one technology or the other for creating zips.