Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 18847002: Unrevert "Derive synthetic type bounds for expressions" (Closed)

Created:
7 years, 5 months ago by rossberg
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Unrevert "Derive synthetic type bounds for expressions" Reenables https://codereview.chromium.org/17842004 R=jkummerow@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=15552

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -122 lines) Patch
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/typing.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/typing.cc View 12 chunks +204 lines, -121 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
7 years, 5 months ago (2013-07-08 13:16:44 UTC) #1
Jakob Kummerow
LGTM (pretty much rubber-stamped).
7 years, 5 months ago (2013-07-08 13:19:37 UTC) #2
rossberg
7 years, 5 months ago (2013-07-08 13:20:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15552 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698