git_cl.py - Issue 1884673004: Fix regression in git cl for Gerrit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 1884673004: Fix regression in git cl for Gerrit. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index 63d01adadd8a85b2047a6ab1f6156046e3d9e6e8..0aa942dc3baf5428a0b886cacf299546838d1f50 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -2080,7 +2080,8 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase):

options = options or []

issue = issue or self.GetIssue()

assert issue, 'issue required to query Gerrit'

- return gerrit_util.GetChangeDetail(self._GetGerritHost(), options, issue)

+ return gerrit_util.GetChangeDetail(self._GetGerritHost(), str(issue),

+ options)

def CMDLand(self, force, bypass_hooks, verbose):

if git_common.is_dirty_git_tree('land'):

« no previous file with comments | « no previous file | no next file » | no next file with comments »