Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1884653002: [field type tracking] Use breadth first traversal instead of recursion when updating field types. (Closed)

Created:
4 years, 8 months ago by Igor Sheludko
Modified:
4 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[field type tracking] Use breadth first traversal instead of recursion when updating field types. ... to avoid potential stack overflow when updating happens near the stack limit. BUG=chromium:599440 LOG=Y Committed: https://crrev.com/a021c6af22d44cc33beb5756285f7d6eb50152d4 Cr-Commit-Position: refs/heads/master@{#35436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -16 lines) Patch
M src/objects.cc View 1 chunk +31 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884653002/1
4 years, 8 months ago (2016-04-12 16:14:10 UTC) #2
Igor Sheludko
PTAL
4 years, 8 months ago (2016-04-12 16:17:55 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-12 16:39:01 UTC) #6
Jakob Kummerow
LGTM, thanks!
4 years, 8 months ago (2016-04-13 09:44:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884653002/1
4 years, 8 months ago (2016-04-13 09:44:49 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 09:47:12 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 09:48:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a021c6af22d44cc33beb5756285f7d6eb50152d4
Cr-Commit-Position: refs/heads/master@{#35436}

Powered by Google App Engine
This is Rietveld 408576698