Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1884633002: Always start AVDA codec configuration thread. (Closed)

Created:
4 years, 8 months ago by liberato (no reviews please)
Modified:
4 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always start AVDA codec configuration thread. AVDA::Initialize now starts the configuration thread, even if deferred initialization is not enabled. Otherwise, ResetCodecState might still try async re-initialization of the codec if an error happens, or if the Android API level doesn't allow MediaCodec::flush. If the thread isn't started, then it will crash when it tries to post the codec configuration task to it. BUG=602584 Committed: https://crrev.com/d30026966d0d7f2ae74682876eb9b5d371565df7 Cr-Commit-Position: refs/heads/master@{#386722}

Patch Set 1 #

Patch Set 2 : fixed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/common/gpu/media/android_video_decode_accelerator.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
DaleCurtis
lgtm seems cleaner than trying to restart in reset.
4 years, 8 months ago (2016-04-12 16:42:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884633002/20001
4 years, 8 months ago (2016-04-12 16:43:31 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 17:14:04 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 17:15:14 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d30026966d0d7f2ae74682876eb9b5d371565df7
Cr-Commit-Position: refs/heads/master@{#386722}

Powered by Google App Engine
This is Rietveld 408576698