Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1884603004: Update widget geometries when transforming a layer (Closed)

Created:
4 years, 8 months ago by Sami
Modified:
4 years, 8 months ago
Reviewers:
pdr., Xianzhu
CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update widget geometries when transforming a layer Previously widget geometries were only updated during actual layouts. However if only the transform of a layer is changed, this doesn't cause a layout and can result in stale widget geometries. In the linked bug this causes a FrameView to remain throttled even though its transform was changed to make the FrameView visible again. BUG=601353 Committed: https://crrev.com/0265532ea6ef8cfdccbe411647bbdb2b4e7c07c8 Cr-Commit-Position: refs/heads/master@{#387271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Sami
PTAL.
4 years, 8 months ago (2016-04-13 09:43:17 UTC) #3
Xianzhu
lgtm. +pdr@ for Source/web.
4 years, 8 months ago (2016-04-13 17:35:21 UTC) #5
pdr.
On 2016/04/13 at 17:35:21, wangxianzhu wrote: > lgtm. > > +pdr@ for Source/web. LGTM
4 years, 8 months ago (2016-04-13 17:54:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884603004/1
4 years, 8 months ago (2016-04-14 09:27:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 09:33:02 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 09:34:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0265532ea6ef8cfdccbe411647bbdb2b4e7c07c8
Cr-Commit-Position: refs/heads/master@{#387271}

Powered by Google App Engine
This is Rietveld 408576698