Factor out toolset definitions in a separate gypi file

Factor out toolset definitions in a separate gypi file

That way, third-party libraries use the correct toolset settings.

BUG=v8:2745
R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15585

[Jakob Kummerow, 2013-07-09 07:44:43]

I disagree with this change.

standalone.gypi should be used for things specific to standalone builds.

common.gypi should be used for definitions shared by all targets, and should be
completely agnostic of whether we're doing a standalone or an embedded build.
That means targets depending on it should include it explicitly (as we currently
do in v8.gyp, d8.gyp, and various samples' *.gyp files).

[jochen (gone - plz use gerrit), 2013-07-09 07:48:13]

On 2013/07/09 07:44:43, Jakob wrote:
> I disagree with this change.
> 
> standalone.gypi should be used for things specific to standalone builds.
> 
> common.gypi should be used for definitions shared by all targets, and should
be
> completely agnostic of whether we're doing a standalone or an embedded build.
> That means targets depending on it should include it explicitly (as we
currently
> do in v8.gyp, d8.gyp, and various samples' *.gyp files).

the problem I'm trying to solve is that third_party sources can't directly
include v8 specific gypi files.

An alternative is duplicating the entire toolset-specific compiler flags in
standalone.gypi in a conditional block with v8_code == 0. Or maybe moving that
into another gypi file that is included by common.gypi and standalone.gypi

wdyt?

[jochen (gone - plz use gerrit), 2013-07-09 13:25:58]

updated as discussed

PTAL

[jochen (gone - plz use gerrit), 2013-07-10 08:26:22]

PTAL

I removed v8_can_use_unalligned_memory_access, because it isn't used anywhere

[Jakob Kummerow, 2013-07-10 09:19:48]

LGTM with comments.

Thanks for your patience with all the iterations on this CL! I really like the
latest version.

https://codereview.chromium.org/18846002/diff/15001/build/android.gypi
File build/android.gypi (right):

https://codereview.chromium.org/18846002/diff/15001/build/android.gypi#newcode30
build/android.gypi:30: #
http://src.chromium.org/viewvc/chrome/trunk/src/build/toolchain.gypi
accidental edit? I don't think Chromium has a toolchain.gypi.

https://codereview.chromium.org/18846002/diff/15001/src/third_party/vtune/v8v...
File src/third_party/vtune/v8vtune.gyp (right):

https://codereview.chromium.org/18846002/diff/15001/src/third_party/vtune/v8v...
src/third_party/vtune/v8vtune.gyp:32: 'includes': ['../build/toolchain.gypi',
'../build/features.gypi'],
Why did the relative path change? Are you sure this still works?

[jochen (gone - plz use gerrit), 2013-07-10 11:00:28]

https://codereview.chromium.org/18846002/diff/15001/build/android.gypi
File build/android.gypi (right):

https://codereview.chromium.org/18846002/diff/15001/build/android.gypi#newcode30
build/android.gypi:30: #
http://src.chromium.org/viewvc/chrome/trunk/src/build/toolchain.gypi
On 2013/07/10 09:19:48, Jakob wrote:
> accidental edit? I don't think Chromium has a toolchain.gypi.

Done.

https://codereview.chromium.org/18846002/diff/15001/src/third_party/vtune/v8v...
File src/third_party/vtune/v8vtune.gyp (right):

https://codereview.chromium.org/18846002/diff/15001/src/third_party/vtune/v8v...
src/third_party/vtune/v8vtune.gyp:32: 'includes': ['../build/toolchain.gypi',
'../build/features.gypi'],
On 2013/07/10 09:19:48, Jakob wrote:
> Why did the relative path change? Are you sure this still works?

oops, fixed

[jochen (gone - plz use gerrit), 2013-07-10 11:15:26]

Committed patchset #6 manually as r15585 (presubmit successful).