Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1884593002: [wasm] Add a cctest for the stack on a wasm trap (Closed)

Created:
4 years, 8 months ago by Clemens Hammacher
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@wasm-throw-error
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add a cctest for the stack on a wasm trap In contrast to the existing cctest, this time the error is not thrown from javascript, but by a trap in wasm. And in contrast to the mjsunit tests, this checks the detailed stack trace, not the simple one. R=jfb@chromium.org, mstarzinger@chromium.org, titzer@chromium.org BUG= Committed: https://crrev.com/ec8e14e6976ce879e24dc87c46905ad0d57183ee Cr-Commit-Position: refs/heads/master@{#35665}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : address JF's comments #

Patch Set 4 : obey the c++ style guide (variable names & comments) #

Patch Set 5 : one more c++ style fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -20 lines) Patch
M test/cctest/wasm/test-wasm-stack.cc View 1 2 3 2 chunks +59 lines, -17 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 2 3 4 4 chunks +16 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (3 generated)
Clemens Hammacher
4 years, 8 months ago (2016-04-12 14:47:32 UTC) #1
Clemens Hammacher
Oh damn, looks like I need to rebase...
4 years, 8 months ago (2016-04-12 14:58:20 UTC) #2
Clemens Hammacher
On 2016/04/12 at 14:58:20, Clemens Hammacher wrote: > Oh damn, looks like I need to ...
4 years, 8 months ago (2016-04-12 15:56:37 UTC) #3
JF
lgtm https://codereview.chromium.org/1884593002/diff/20001/test/cctest/wasm/wasm-run-utils.h File test/cctest/wasm/wasm-run-utils.h (right): https://codereview.chromium.org/1884593002/diff/20001/test/cctest/wasm/wasm-run-utils.h#newcode414 test/cctest/wasm/wasm-run-utils.h:414: const char* debug_name = "wasm_unnamed") It's probably clearer ...
4 years, 8 months ago (2016-04-12 19:38:54 UTC) #4
Clemens Hammacher
https://codereview.chromium.org/1884593002/diff/20001/test/cctest/wasm/wasm-run-utils.h File test/cctest/wasm/wasm-run-utils.h (right): https://codereview.chromium.org/1884593002/diff/20001/test/cctest/wasm/wasm-run-utils.h#newcode414 test/cctest/wasm/wasm-run-utils.h:414: const char* debug_name = "wasm_unnamed") On 2016/04/12 at 19:38:54, ...
4 years, 8 months ago (2016-04-13 07:45:18 UTC) #5
titzer
lgtm
4 years, 8 months ago (2016-04-18 10:41:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884593002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884593002/80001
4 years, 8 months ago (2016-04-20 14:53:12 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-20 15:09:41 UTC) #10
nodir1
4 years, 8 months ago (2016-04-22 18:44:25 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ec8e14e6976ce879e24dc87c46905ad0d57183ee
Cr-Commit-Position: refs/heads/master@{#35665}

Powered by Google App Engine
This is Rietveld 408576698