chrome/browser/spellchecker/spelling_service_client.h - Issue 1884583003: Create a spellcheck component that will allow any embedder to reuse common functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spelling_service_client.h

Issue 1884583003: Create a spellcheck component that will allow any embedder to reuse common functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewers' comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/spellchecker/spellchecker_session_bridge_android.cc ('k') | chrome/browser/spellchecker/spelling_service_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spelling_service_client.h

diff --git a/chrome/browser/spellchecker/spelling_service_client.h b/chrome/browser/spellchecker/spelling_service_client.h

index e96c80e1ac9c3d4491be48a201bbc5ad627bf8df..1fb9764c02e891321989e8ad07ff0d09d879860f 100644

--- a/chrome/browser/spellchecker/spelling_service_client.h

+++ b/chrome/browser/spellchecker/spelling_service_client.h

@@ -17,7 +17,10 @@

class GURL;

class TextCheckClientDelegate;

+namespace spellcheck {

struct SpellCheckResult;

namespace content {

class BrowserContext;

@@ -72,7 +75,7 @@ class SpellingServiceClient : public net::URLFetcherDelegate {

typedef base::Callback<void(

bool /* success */,

const base::string16& /* text */,

- const std::vector<SpellCheckResult>& /* results */)>

+ const std::vector<spellcheck::SpellCheckResult>& /* results */)>

TextCheckCompleteCallback;

SpellingServiceClient();

@@ -93,7 +96,7 @@ class SpellingServiceClient : public net::URLFetcherDelegate {

protected:

// Parses a JSON-RPC response from the Spelling service.

bool ParseResponse(const std::string& data,

- std::vector<SpellCheckResult>* results);

+ std::vector<spellcheck::SpellCheckResult>* results);

private:

struct TextCheckCallbackData {