chrome/browser/spellchecker/spellcheck_message_filter_platform.h - Issue 1884583003: Create a spellcheck component that will allow any embedder to reuse common functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_message_filter_platform.h

Issue 1884583003: Create a spellcheck component that will allow any embedder to reuse common functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewers' comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/spellchecker/spellcheck_message_filter.cc ('k') | chrome/browser/spellchecker/spellcheck_message_filter_platform_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_message_filter_platform.h

diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_platform.h b/chrome/browser/spellchecker/spellcheck_message_filter_platform.h

index 1c2d39cb2b085523e9225a85f14dc453745b4f98..48ea9f61e907f4f8114ddeb4decf6b90b2058d99 100644

--- a/chrome/browser/spellchecker/spellcheck_message_filter_platform.h

+++ b/chrome/browser/spellchecker/spellcheck_message_filter_platform.h

@@ -10,7 +10,7 @@

#include "base/macros.h"

#include "build/build_config.h"

#include "chrome/browser/spellchecker/spellcheck_message_filter.h"

-#include "chrome/common/spellcheck_result.h"

+#include "components/spellcheck/common/spellcheck_result.h"

#include "content/public/browser/browser_message_filter.h"

class SpellCheckerSessionBridge;

@@ -30,8 +30,8 @@ class SpellCheckMessageFilterPlatform : public content::BrowserMessageFilter {

// local and remote stays type SPELLING, all others are flagged GRAMMAR.

// (This is needed to force gray underline for remote-only results.)

static void CombineResults(

- std::vector<SpellCheckResult>* remote_results,

- const std::vector<SpellCheckResult>& local_results);

+ std::vector<spellcheck::SpellCheckResult>* remote_results,

+ const std::vector<spellcheck::SpellCheckResult>& local_results);

private:

friend class TestingSpellCheckMessageFilter;

@@ -47,7 +47,7 @@ class SpellCheckMessageFilterPlatform : public content::BrowserMessageFilter {

void OnRequestTextCheck(int route_id,

int identifier,

const base::string16& text,

- std::vector<SpellCheckMarker> markers);

+ std::vector<spellcheck::SpellCheckMarker> markers);

int ToDocumentTag(int route_id);

void RetireDocumentTag(int route_id);