Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6143)

Unified Diff: chrome/browser/spellchecker/spellcheck_message_filter.h

Issue 1884583003: Create a spellcheck component that will allow any embedder to reuse common functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewers' comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_message_filter.h
diff --git a/chrome/browser/spellchecker/spellcheck_message_filter.h b/chrome/browser/spellchecker/spellcheck_message_filter.h
index 43671a89959c7522ad9923d78f5b1b3804dccd49..bd0b8f629251d7f5e7ac814d0f24b7832a35a267 100644
--- a/chrome/browser/spellchecker/spellcheck_message_filter.h
+++ b/chrome/browser/spellchecker/spellcheck_message_filter.h
@@ -12,9 +12,12 @@
#include "chrome/browser/spellchecker/spelling_service_client.h"
#include "content/public/browser/browser_message_filter.h"
-class SpellCheckMarker;
class SpellcheckService;
+
+namespace spellcheck {
+class SpellCheckMarker;
struct SpellCheckResult;
+}
// A message filter implementation that receives spell checker requests from
// SpellCheckProvider.
@@ -39,17 +42,17 @@ class SpellCheckMessageFilter : public content::BrowserMessageFilter {
void OnCallSpellingService(int route_id,
int identifier,
const base::string16& text,
- std::vector<SpellCheckMarker> markers);
+ std::vector<spellcheck::SpellCheckMarker> markers);
// A callback function called when the Spelling service finishes checking
// text. Sends the given results to a renderer.
void OnTextCheckComplete(
int route_id,
int identifier,
- const std::vector<SpellCheckMarker>& markers,
+ const std::vector<spellcheck::SpellCheckMarker>& markers,
bool success,
const base::string16& text,
- const std::vector<SpellCheckResult>& results);
+ const std::vector<spellcheck::SpellCheckResult>& results);
// Checks the user profile and sends a JSON-RPC request to the Spelling
// service if a user enables the "Ask Google for suggestions" option. When we
@@ -61,7 +64,7 @@ class SpellCheckMessageFilter : public content::BrowserMessageFilter {
const base::string16& text,
int route_id,
int identifier,
- const std::vector<SpellCheckMarker>& markers);
+ const std::vector<spellcheck::SpellCheckMarker>& markers);
#endif
// Can be overridden for testing.
« no previous file with comments | « chrome/browser/spellchecker/feedback_sender_unittest.cc ('k') | chrome/browser/spellchecker/spellcheck_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698