chrome/browser/spellchecker/feedback_sender.h - Issue 1884583003: Create a spellcheck component that will allow any embedder to reuse common functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/feedback_sender.h

Issue 1884583003: Create a spellcheck component that will allow any embedder to reuse common functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewers' comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm ('k') | chrome/browser/spellchecker/feedback_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/feedback_sender.h

diff --git a/chrome/browser/spellchecker/feedback_sender.h b/chrome/browser/spellchecker/feedback_sender.h

index 42d6aacc11ea1f9a956334a91c889a0a4a5315e7..c5cd8466b0cb52489a94cb5f5b0c708bafb28b92 100644

--- a/chrome/browser/spellchecker/feedback_sender.h

+++ b/chrome/browser/spellchecker/feedback_sender.h

@@ -31,9 +31,6 @@

#include "net/url_request/url_fetcher_delegate.h"

#include "url/gurl.h"

-class SpellCheckMarker;

-struct SpellCheckResult;

namespace net {

class URLFetcher;

class URLRequestContextGetter;

@@ -41,6 +38,9 @@ class URLRequestContextGetter;

namespace spellcheck {

+class SpellCheckMarker;

+struct SpellCheckResult;

namespace {

// Constants for the feedback field trial.

@@ -103,7 +103,7 @@ class FeedbackSender : public base::SupportsWeakPtr<FeedbackSender>,

void OnSpellcheckResults(int renderer_process_id,

const base::string16& text,

const std::vector<SpellCheckMarker>& markers,

- std::vector<SpellCheckResult>* results);

+ std::vector<spellcheck::SpellCheckResult>* results);

// Receives updated language and country code for feedback. Finalizes and

// sends out all of the feedback data.