chrome/browser/renderer_context_menu/spelling_menu_observer.cc - Issue 1884583003: Create a spellcheck component that will allow any embedder to reuse common functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/spelling_menu_observer.cc

Issue 1884583003: Create a spellcheck component that will allow any embedder to reuse common functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewers' comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/spelling_menu_observer.h ('k') | chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/spelling_menu_observer.cc

diff --git a/chrome/browser/renderer_context_menu/spelling_menu_observer.cc b/chrome/browser/renderer_context_menu/spelling_menu_observer.cc

index 9838234f26b5f2d06ead55e9ee2a03c5cd78e6c1..ad35cb64c38652813da1838b739aaea89a6292ca 100644

--- a/chrome/browser/renderer_context_menu/spelling_menu_observer.cc

+++ b/chrome/browser/renderer_context_menu/spelling_menu_observer.cc

@@ -24,9 +24,9 @@

#include "chrome/common/chrome_switches.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/spellcheck_common.h"

-#include "chrome/common/spellcheck_result.h"

#include "chrome/grit/generated_resources.h"

#include "components/prefs/pref_service.h"

+#include "components/spellcheck/common/spellcheck_result.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/render_widget_host.h"

#include "content/public/browser/render_widget_host_view.h"

@@ -37,6 +37,7 @@

#include "ui/gfx/geometry/rect.h"

using content::BrowserThread;

+using spellcheck::SpellCheckResult;

const int kMaxSpellingSuggestions = 3;