Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1884583002: Add structural equivalence test for AST nodes. (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+709 lines, -7 lines) Patch
M pkg/compiler/lib/src/serialization/equivalence.dart View 3 chunks +709 lines, -7 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 8 months ago (2016-04-12 14:30:38 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1884583002/diff/1/pkg/compiler/lib/src/serialization/equivalence.dart File pkg/compiler/lib/src/serialization/equivalence.dart (right): https://codereview.chromium.org/1884583002/diff/1/pkg/compiler/lib/src/serialization/equivalence.dart#newcode811 pkg/compiler/lib/src/serialization/equivalence.dart:811: var object1, var object2, String property, Node node1, ...
4 years, 8 months ago (2016-04-12 17:36:06 UTC) #3
Johnni Winther
https://codereview.chromium.org/1884583002/diff/1/pkg/compiler/lib/src/serialization/equivalence.dart File pkg/compiler/lib/src/serialization/equivalence.dart (right): https://codereview.chromium.org/1884583002/diff/1/pkg/compiler/lib/src/serialization/equivalence.dart#newcode811 pkg/compiler/lib/src/serialization/equivalence.dart:811: var object1, var object2, String property, Node node1, Node ...
4 years, 8 months ago (2016-04-13 07:34:02 UTC) #4
Johnni Winther
4 years, 8 months ago (2016-04-13 07:47:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
68a92257b3d751aaaa5822ccc41c713d2e782037 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698