Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: tools/metrics/actions/actions.xml

Issue 1884573004: Add user actions to record media controls interaction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index e71fdf8e9245707b2779dcecb1ab1b16f245f064..c4b9b644969447fa13dd066429b105f43c8397f6 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -7835,6 +7835,98 @@ should be able to be added at any place in this file.
<description>A tab is no longer audible.</description>
</action>
+<action name="Media.Controls.Cast">
+ <owner>mlamouri@chromium.org</owner>
+ <description>The user clicked on the cast controls button.</description>
+</action>
+
+<action name="Media.Controls.CastOverlay">
+ <owner>mlamouri@chromium.org</owner>
+ <description>The user clicked on the cast overlay button.</description>
+</action>
+
+<action name="Media.Controls.ClosedCaptionHide">
+ <owner>mlamouri@chromium.org</owner>
+ <description>The user hide the closed caption from the controls.</description>
Ilya Sherman 2016/04/13 19:12:12 nit: s/hide/hid, or possibly "chose to hide" or so
mlamouri (slow - plz ping) 2016/04/14 15:46:30 Went with "hid". It's short and clear enough IMO.
+</action>
+
+<action name="Media.Controls.ClosedCaptionShow">
+ <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <description>Please enter the description of the metric.</description>
Ilya Sherman 2016/04/13 19:12:13 Please update :)
mlamouri (slow - plz ping) 2016/04/14 15:46:30 That's really odd. I wonder if it was auto-generat
+</action>
+
+<action name="Media.Controls.ClosedCoptionShow">
Ilya Sherman 2016/04/13 19:12:13 nit: typo -- please merge this into the above.
mlamouri (slow - plz ping) 2016/04/14 15:46:31 Done.
+ <owner>mlamouri@chromium.org</owner>
+ <description>
+ The user showed the closed caption from the controls.
+ </description>
+</action>
+
+<action name="Media.Controls.EnterFullscreen">
+ <owner>mlamouri@chromium.org</owner>
+ <description>The user entered fullscreen mode for the controls.</description>
Ilya Sherman 2016/04/13 19:12:12 nit: Did you mean "from the controls"?
mlamouri (slow - plz ping) 2016/04/14 15:46:31 Yes :)
+</action>
+
+<action name="Media.Controls.ExitFullscreen">
+ <owner>mlamouri@chromium.org</owner>
+ <description>The user left fullscreen mode for the controls.</description>
Ilya Sherman 2016/04/13 19:12:13 nit: Did you mean "from the controls"?
mlamouri (slow - plz ping) 2016/04/14 15:46:30 Did you mean I'm abusing copy-paste? :)
+</action>
+
+<action name="Media.Controls.Mute">
+ <owner>mlamouri@chromium.org</owner>
+ <description>The user muted a media from the controls.</description>
Ilya Sherman 2016/04/13 19:12:13 nit: "a media" -> "a media element" (here and thro
mlamouri (slow - plz ping) 2016/04/14 15:46:30 Done.
+</action>
+
+<action name="Media.Controls.Pause">
+ <owner>mlamouri@chromium.org</owner>
+ <description>The user paused a media from the controls.</description>
+</action>
+
+<action name="Media.Controls.Play">
+ <owner>mlamouri@chromium.org</owner>
+ <description>The user played a media from the controls.</description>
+</action>
+
+<action name="Media.Controls.PlayOverlay">
+ <owner>mlamouri@chromium.org</owner>
+ <description>
+ The user played a media from the play overlay button.
+ </description>
+</action>
+
+<action name="Media.Controls.ScrubbingBegin">
+ <owner>mlamouri@chromium.org</owner>
+ <description>
+ The user started to interact with the control's scrubber.
+ </description>
+</action>
+
+<action name="Media.Controls.ScrubbingEnd">
Ilya Sherman 2016/04/13 19:12:12 I'm not sure that you'll really get much value fro
mlamouri (slow - plz ping) 2016/04/14 15:46:30 As said above, I think the time it takes to scrub
Ilya Sherman 2016/04/14 20:41:26 That might be true, but how do you plan to view th
+ <owner>mlamouri@chromium.org</owner>
+ <description>
+ The user stopped interacting with the control's scrubber.
+ </description>
+</action>
+
+<action name="Media.Controls.Unmute">
+ <owner>mlamouri@chromium.org</owner>
+ <description>The user unmuted a media from the controls.</description>
+</action>
+
+<action name="Media.Controls.VolumeChangeBegin">
+ <owner>mlamouri@chromium.org</owner>
+ <description>
+ The user started to interact with the control's volume slider.
+ </description>
+</action>
+
+<action name="Media.Controls.VolumeChangeEnd">
Ilya Sherman 2016/04/13 19:12:12 Ditto.
mlamouri (slow - plz ping) 2016/04/14 15:46:30 As said above, that one is mostly completeness and
+ <owner>mlamouri@chromium.org</owner>
+ <description>
+ The user stopped interacting with the control's volume slider.
+ </description>
+</action>
+
<action name="MediaContextMenu_Controls">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>

Powered by Google App Engine
This is Rietveld 408576698