Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1884573003: S390: [compiler] Add relocatable pointer constants for wasm memory references. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [compiler] Add relocatable pointer constants for wasm memory references. port 52148c41c948f4e70778de758fb1a0ae118cecc2 Original Commit Message: Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. R=gdeepti@google.com, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/949d3226880e155e7d14827c678197b4e08c2a8c Cr-Commit-Position: refs/heads/master@{#35426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-12 18:53:34 UTC) #1
JoranSiu
On 2016/04/12 18:53:34, john.yan wrote: > PTAL lgtm
4 years, 8 months ago (2016-04-12 19:14:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884573003/1
4 years, 8 months ago (2016-04-12 20:02:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 20:21:49 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 20:23:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/949d3226880e155e7d14827c678197b4e08c2a8c
Cr-Commit-Position: refs/heads/master@{#35426}

Powered by Google App Engine
This is Rietveld 408576698