Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2734)

Unified Diff: components/browsing_data_ui/history_notice_utils.cc

Issue 1884553002: Add a testing switch to override the query for other forms of browsing history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Renamed the switch. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/browsing_data_ui/history_notice_utils.h ('k') | ios/chrome/app/resources/history/history.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browsing_data_ui/history_notice_utils.cc
diff --git a/components/browsing_data_ui/history_notice_utils.cc b/components/browsing_data_ui/history_notice_utils.cc
index c651520c80b4ca7151bb3082d255392d4c311c6a..1116c3f283caf34a7b0152915b347d549462d6d7 100644
--- a/components/browsing_data_ui/history_notice_utils.cc
+++ b/components/browsing_data_ui/history_notice_utils.cc
@@ -10,6 +10,12 @@
namespace browsing_data_ui {
+namespace testing {
+
+bool g_override_other_forms_of_browsing_history_query = false;
+
+}
+
void ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
const ProfileSyncService* sync_service,
history::WebHistoryService* history_service,
@@ -18,7 +24,8 @@ void ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
!sync_service->IsSyncActive() ||
sync_service->IsUsingSecondaryPassphrase() ||
!history_service ||
- !history_service->HasOtherFormsOfBrowsingHistory()) {
+ (!testing::g_override_other_forms_of_browsing_history_query &&
+ !history_service->HasOtherFormsOfBrowsingHistory())) {
callback.Run(false);
return;
}
« no previous file with comments | « components/browsing_data_ui/history_notice_utils.h ('k') | ios/chrome/app/resources/history/history.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698