Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: components/browsing_data_ui/history_notice_utils.cc

Issue 1884553002: Add a testing switch to override the query for other forms of browsing history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browsing_data_ui/history_notice_utils.cc
diff --git a/components/browsing_data_ui/history_notice_utils.cc b/components/browsing_data_ui/history_notice_utils.cc
index c651520c80b4ca7151bb3082d255392d4c311c6a..ac0278a547a4fc14b70485db4a20fe77305554c6 100644
--- a/components/browsing_data_ui/history_notice_utils.cc
+++ b/components/browsing_data_ui/history_notice_utils.cc
@@ -10,6 +10,12 @@
namespace browsing_data_ui {
+namespace testing {
+
+bool kOverrideOtherFormsOfBrowsingHistoryQuery = false;
+
+}
+
void ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
const ProfileSyncService* sync_service,
history::WebHistoryService* history_service,
@@ -18,7 +24,8 @@ void ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
!sync_service->IsSyncActive() ||
sync_service->IsUsingSecondaryPassphrase() ||
!history_service ||
- !history_service->HasOtherFormsOfBrowsingHistory()) {
+ (!testing::kOverrideOtherFormsOfBrowsingHistoryQuery &&
+ !history_service->HasOtherFormsOfBrowsingHistory())) {
callback.Run(false);
return;
}

Powered by Google App Engine
This is Rietveld 408576698