Add a testing switch to override the query for other forms of browsing history

chrome/browser/ui/webui/history_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/history_ui.h"
 
+#include <string>
+
 #include "base/command_line.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/ui/webui/browsing_history_handler.h"
 #include "chrome/browser/ui/webui/metrics_handler.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
+#include "components/browsing_data_ui/history_notice_utils.h"
 #include "components/prefs/pref_service.h"
 #include "components/search/search.h"
 #include "components/signin/core/browser/signin_manager.h"
+#include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/browser/web_ui_data_source.h"
 #include "grit/browser_resources.h"
 #include "grit/components_scaled_resources.h"
 #include "grit/components_strings.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 #if !defined(OS_ANDROID)
@@ skipping 132 matching lines @@
   web_ui->AddMessageHandler(new MetricsHandler());
 
   // On mobile we deal with foreign sessions differently.
 #if !defined(OS_ANDROID)
   if (search::IsInstantExtendedAPIEnabled()) {
     web_ui->AddMessageHandler(new browser_sync::ForeignSessionHandler());
     web_ui->AddMessageHandler(new HistoryLoginHandler());
   }
 #endif
 
+  // TODO(crbug.com/595332): Since the API to query other forms of browsing
+  // history is not ready yet, make it possible to test the history UI as if
+  // it were. If the user opens chrome://history/?reset_ofbh, we will assume
+  // that other forms of browsing history exist (for all accounts), and we will
+  // also reset the one-time notice shown in the Clear Browsing Data dialog.
+  // This code should be removed as soon as the API is ready.
+  GURL url = web_ui->GetWebContents()->GetVisibleURL();
+  if (url.has_query() && url.query() == "reset_ofbh") {
+    Profile::FromWebUI(web_ui)->GetPrefs()->SetInteger(
+        prefs::kClearBrowsingDataHistoryNoticeShownTimes, 0);
+    browsing_data_ui::testing::kOverrideOtherFormsOfBrowsingHistoryQuery = true;

[Dan Beam, 2016/04/21 03:12:55]

this is a constant naming form (kConstantThing)

this should probably be g_other_forms_of_browsing_history (if it's global) or
just other_forms_of_browsing_history otherwise

[msramek, 2016/04/21 08:50:30]

Done.

+  }
+
   // Set up the chrome://history-frame/ source.
   Profile* profile = Profile::FromWebUI(web_ui);
   content::WebUIDataSource::Add(profile, CreateHistoryUIHTMLSource(profile));
 }
 
 HistoryUI::~HistoryUI() {}
 
 // static
 base::RefCountedMemory* HistoryUI::GetFaviconResourceBytes(
       ui::ScaleFactor scale_factor) {
   return ResourceBundle::GetSharedInstance().
       LoadDataResourceBytesForScale(IDR_HISTORY_FAVICON, scale_factor);
 }