Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1884523002: Extract update_scripts out of annotated_run (Closed)

Created:
4 years, 8 months ago by Paweł Hajdan Jr.
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Extract update_scripts out of annotated_run This is needed for kitchen_run, and has been extracted out of https://codereview.chromium.org/1869053002 . BUG=chromium:593999 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299854

Patch Set 1 #

Patch Set 2 : presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -74 lines) Patch
M scripts/slave/annotated_run.py View 3 chunks +2 lines, -70 lines 0 comments Download
M scripts/slave/unittests/annotated_run_test.py View 1 2 chunks +10 lines, -4 lines 0 comments Download
A scripts/slave/update_scripts.py View 1 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884523002/1
4 years, 8 months ago (2016-04-12 12:09:33 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/3846)
4 years, 8 months ago (2016-04-12 12:17:23 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884523002/20001
4 years, 8 months ago (2016-04-12 12:42:44 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-12 12:46:35 UTC) #8
Paweł Hajdan Jr.
4 years, 8 months ago (2016-04-12 12:47:45 UTC) #10
tandrii(chromium)
lgtm
4 years, 8 months ago (2016-04-12 13:49:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884523002/20001
4 years, 8 months ago (2016-04-12 13:51:23 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 13:55:42 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299854

Powered by Google App Engine
This is Rietveld 408576698