Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1884513002: [chrome.displaySource][WiFi Display] Send media stream to sink (browser part) (Closed)

Created:
4 years, 8 months ago by Mikhail
Modified:
4 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, e_hakkinen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chrome.displaySource][WiFi Display] Send media stream to sink (browser part) This patch adds functionality for sending packetized media stream to a sink device over UDP (browser process part), i.e. it provides 'WiFiDisplayMediaService' mojo service implementation. This patch is based on initial patch from Eero Hakkinen <eero.hakkinen@intel.com>;. BUG=242107 Committed: https://crrev.com/65509e5a72ebf2954e476d0d7e2cdd8351ac2708 Cr-Commit-Position: refs/heads/master@{#387664}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Error handling. Threading. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -0 lines) Patch
A extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.h View 1 1 chunk +47 lines, -0 lines 0 comments Download
A extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc View 1 1 chunk +134 lines, -0 lines 0 comments Download
M extensions/browser/mojo/service_registration.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Mikhail
Please take a look.
4 years, 8 months ago (2016-04-12 11:09:20 UTC) #4
shalamov
https://codereview.chromium.org/1884513002/diff/20001/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc File extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc (right): https://codereview.chromium.org/1884513002/diff/20001/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc#newcode96 extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc:96: if (code != net::ERR_IO_PENDING) { Should we try to ...
4 years, 8 months ago (2016-04-13 13:23:16 UTC) #5
shalamov
lgtm
4 years, 8 months ago (2016-04-14 13:33:38 UTC) #6
Mikhail
@Antony, could you pls take a look?
4 years, 8 months ago (2016-04-14 13:35:35 UTC) #7
asargent_no_longer_on_chrome
lgtm
4 years, 8 months ago (2016-04-15 16:24:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884513002/40001
4 years, 8 months ago (2016-04-15 18:05:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-04-15 18:59:33 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 19:00:36 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65509e5a72ebf2954e476d0d7e2cdd8351ac2708
Cr-Commit-Position: refs/heads/master@{#387664}

Powered by Google App Engine
This is Rietveld 408576698