Dump C++ symbols and merge into v8 log.

tools/dump-cpp.py

+#!/usr/bin/env python
+#
+# Copyright 2016 the V8 project authors. All rights reserved.
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+#     * Redistributions of source code must retain the above copyright
+#       notice, this list of conditions and the following disclaimer.
+#     * Redistributions in binary form must reproduce the above
+#       copyright notice, this list of conditions and the following
+#       disclaimer in the documentation and/or other materials provided
+#       with the distribution.
+#     * Neither the name of Google Inc. nor the names of its
+#       contributors may be used to endorse or promote products derived
+#       from this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+# This script executes the tickprocessor, collects all dumped C++ symbols,

[fmeawad, 2016/04/20 22:54:22]

It no longer executes the "tickprocessor"

[lpy, 2016/04/20 23:10:37]

Done.

+# and merges them into v8.log.

[fmeawad, 2016/04/20 22:54:22]

back into ...

[lpy, 2016/04/20 23:10:37]

Done.

+
+import os
+import platform
+import re
+import subprocess
+import sys
+
+def isFileExecutable(fPath):
+  return os.path.isfile(fPath) and os.access(fPath, os.X_OK)
+
+if __name__ == '__main__':
+  JS_FILES = ['splaytree.js', 'codemap.js', 'csvparser.js', 'consarray.js',
+              'profile.js', 'logreader.js', 'tickprocessor.js', 'SourceMap.js',

[fmeawad, 2016/04/20 22:54:22]

Do we still need the tickprocessor.js? can we avoid that?

[lpy, 2016/04/20 23:10:37]

Yes, we need to import it.

[fmeawad, 2016/04/20 23:15:11]

We should make the functionality in tickprocessor that is needed as part of a
util or something, we should not depend on it.

+              'dumpcpp.js']
+  tools_path = os.path.dirname(os.path.realpath(__file__))
+  on_windows = True if platform.system() == 'Windows' else False
+  for i in range(0, len(JS_FILES)):
+    JS_FILES[i] = os.path.join(tools_path, JS_FILES[i])
+
+  args = []
+  log_file = 'v8.log'
+  debug = False
+  for i in range(1, len(sys.argv)):
+    if sys.argv[i] == '--debug':
+      debug = True
+      continue
+    args.append(sys.argv[i])
+    if not sys.argv[i].startswith('-'):
+      log_file = sys.argv[i]
+
+  if on_windows:
+    args.append('--windows')
+
+  with open(log_file, 'r') as f:
+    lines = f.readlines()
+
+  d8_line = re.search(',\"(.*d8)', ''.join(lines))
+  if d8_line:
+    d8_exec = d8_line.groups()[0]
+  else:
+    print 'No d8 binary path found in {}.'.format(log_file)

[fmeawad, 2016/04/20 22:54:21]

I think that would give you the path to v8.log?

[lpy, 2016/04/20 23:10:37]

I am not sure if it's guaranteed that we can have the d8 path from v8 log.

[fmeawad, 2016/04/20 23:15:11]

Then the error message is misleading

+    exit(-1)
+
+  if on_windows:
+    args = [d8_exec] + JS_FILES + ['--'] + args
+  else:
+    args = [d8_exec] + JS_FILES + ['--'] + args

[fmeawad, 2016/04/20 22:54:21]

I do not see a different between the if and else clauses? is it something that
looks the same?

[lpy, 2016/04/20 23:10:37]

Done.

+
+  with open(log_file) as f:
+    sp = subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE, stdin=f)
+  out, err = sp.communicate()
+  if debug:
+    print err
+  returncode = sp.returncode
+  if returncode != 0:

[fmeawad, 2016/04/20 22:54:22]

No need to store the return code, just use it.

[lpy, 2016/04/20 23:10:37]

Done.

+    print out
+    exit(-1)
+
+  if on_windows and out:
+    out = re.sub('\r+\n', '\n', out)
+
+  is_written = False if out else True
+  with open(log_file, 'w+') as f:
+    for line in lines:
+      if not is_written and line.startswith('tick'):
+        f.write(out)
+        is_written = True
+      f.write(line)