Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1884453002: Revert of Convert //net and //chromecast to std::unordered_* (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
Reviewers:
lcwu1, mmenke, davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert //net and //chromecast to std::unordered_* (patchset #5 id:80001 of https://codereview.chromium.org/1869503003/ ) Reason for revert: Speculatively reverting this since it was in the blamelist https://chromium.googlesource.com/chromium/src/+log/39399be2c6a0063520d8d9b289e8f7b31e1eb094%5E..4241ad1dee5396c329a5e9379c3db3027f1b6456?pretty=fuller that I came up with after analyzing the content_browsertests failures (DownloadContentTest) on https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/27572 and https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/11573 Original issue's description: > Convert //net and //chromecast to std::unordered_* > > Do //chromecast at the same time as //net since there aren't many > uses in //chromecast and one needs to be changed to mirror a //net > API change. > > BUG=576864, 554287 > > Committed: https://crrev.com/4241ad1dee5396c329a5e9379c3db3027f1b6456 > Cr-Commit-Position: refs/heads/master@{#386485} TBR=mmenke@chromium.org,lcwu@chromium.org,davidben@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=576864, 554287 Committed: https://crrev.com/31ddcd5dea3d3dcdf9e55ba3213d84d1e904aa27 Cr-Commit-Position: refs/heads/master@{#386624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -145 lines) Patch
M chromecast/base/device_capabilities_impl.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chromecast/base/device_capabilities_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chromecast/common/cast_resource_delegate.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromecast/net/net_util_cast.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chromecast/net/net_util_cast.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/android/network_change_notifier_android.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/base/address_tracker_linux.h View 4 chunks +8 lines, -9 lines 0 comments Download
M net/base/address_tracker_linux.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/base/address_tracker_linux_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M net/base/mime_util.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M net/base/network_change_notifier.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/base/network_change_notifier_linux.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/base/network_change_notifier_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/network_interfaces_linux.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/network_interfaces_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/network_interfaces_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/platform_mime_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/platform_mime_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/platform_mime_util_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M net/base/platform_mime_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/priority_queue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/cert/crl_set.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/cert/crl_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/backend_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl_v3.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/disk_cache/blockfile/backend_worker_v3.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/memory/mem_backend_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/memory/mem_entry_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.h View 3 chunks +6 lines, -7 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/disk_cache/simple/simple_index.h View 3 chunks +3 lines, -4 lines 0 comments Download
M net/disk_cache/simple/simple_index.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/disk_cache/simple/simple_index_file.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/dns/dns_hosts.h View 2 chunks +18 lines, -6 lines 0 comments Download
M net/http/http_cache.h View 2 chunks +6 lines, -6 lines 0 comments Download
M net/http/http_response_headers.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_response_headers.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_transaction_test_util.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/http/mock_http_cache.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/spdy/http2_write_scheduler.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/write_blocked_list.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/balsa/balsa_headers.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M net/tools/balsa/string_piece_utils.h View 2 chunks +43 lines, -0 lines 0 comments Download
M net/tools/epoll_server/epoll_server.h View 5 chunks +4 lines, -5 lines 0 comments Download
M net/tools/net_watcher/net_watcher.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_server_session_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/test_tools/mock_epoll_server.h View 3 chunks +2 lines, -5 lines 0 comments Download
M net/url_request/url_request_filter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/url_request/url_request_filter.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M net/websockets/websocket_basic_handshake_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
kjellander_chromium
Created Revert of Convert //net and //chromecast to std::unordered_*
4 years, 8 months ago (2016-04-12 08:14:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1884453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1884453002/1
4 years, 8 months ago (2016-04-12 08:14:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 08:19:33 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/31ddcd5dea3d3dcdf9e55ba3213d84d1e904aa27 Cr-Commit-Position: refs/heads/master@{#386624}
4 years, 8 months ago (2016-04-12 08:20:37 UTC) #6
davidben
On 2016/04/12 08:20:37, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 8 months ago (2016-04-12 14:58:37 UTC) #7
mmenke
On 2016/04/12 14:58:37, davidben (OOO 4-4 to 4-11) wrote: > On 2016/04/12 08:20:37, commit-bot: I ...
4 years, 8 months ago (2016-04-12 15:03:17 UTC) #8
kjellander_chromium
4 years, 8 months ago (2016-04-12 15:10:51 UTC) #9
Message was sent while issue was closed.
On 2016/04/12 15:03:17, mmenke wrote:
> On 2016/04/12 14:58:37, davidben (OOO 4-4 to 4-11) wrote:
> > On 2016/04/12 08:20:37, commit-bot: I haz the power wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/31ddcd5dea3d3dcdf9e55ba3213d84d1e904aa27
> > > Cr-Commit-Position: refs/heads/master@{#386624}
> > 
> > Did this end up resolving it?
> 
> Looks like it did -
>
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2....
>  First one that didn't fail had the revert (Among other things, including a
> revert of another CL for a different breakage) -
>
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...

Yeah, I was lucky here. I had a really hard time picking a CL to revert but I
picked this because of the changes in net/url_request/url_request_filter.{cc,h}
that seemed to show up in some of the ASan/LSan stack traces. I can't explain
why an I also couldn't repro locally unfortunately.

Powered by Google App Engine
This is Rietveld 408576698