Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: third_party/WebKit/Source/bindings/tests/idls/modules/TestInterface2Partial.idl

Issue 1884423002: IDL bindings: Avoid extended attributes leaking onto merged interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update documentation. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/idls/modules/TestInterface2Partial.idl
diff --git a/third_party/WebKit/Source/core/html/HTMLNoScriptElement.h b/third_party/WebKit/Source/bindings/tests/idls/modules/TestInterface2Partial.idl
similarity index 71%
copy from third_party/WebKit/Source/core/html/HTMLNoScriptElement.h
copy to third_party/WebKit/Source/bindings/tests/idls/modules/TestInterface2Partial.idl
index 8bf9ebf1fe69c73ccc4d7fd88be12e8051a20246..6419529ba78269f1a4073e79471a6cadfae2f907 100644
--- a/third_party/WebKit/Source/core/html/HTMLNoScriptElement.h
+++ b/third_party/WebKit/Source/bindings/tests/idls/modules/TestInterface2Partial.idl
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2014 Google Inc. All rights reserved.
+ * Copyright (C) 2016 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -28,25 +28,17 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef HTMLNoScriptElement_h
-#define HTMLNoScriptElement_h
-
-#include "core/html/HTMLElement.h"
-
-namespace blink {
-
-// <noscript> is an HTMLElement in script, but we use a separate interface here
-// so HTMLElement's layoutObjectIsNeeded doesn't need to know about it.
-class HTMLNoScriptElement final : public HTMLElement {
-public:
- DECLARE_NODE_FACTORY(HTMLNoScriptElement);
-
-private:
- explicit HTMLNoScriptElement(Document&);
-
- bool layoutObjectIsNeeded(const ComputedStyle&) override;
+// Regression test for https://crbug.com/603782: if the main interface is
+// declared in 'core', the alphabetically first partial interface in 'modules'
+// with a RuntimeEnabled will leak onto all of the other partial interfaces in
+// 'modules' that do not have an extended attributes section (i.e.,
+// TestInterface2Partial2.idl).
+//
+// This test ensures that TestInterface2Partial2 is NOT conditional on the
+// Interface2PartialFeatureName runtime flag.
+[
+ RuntimeEnabled=Interface2PartialFeatureName,
+]
+partial interface TestInterface2 {
+ void voidMethodPartial1(DOMString value);
};
-
-} // namespace blink
-
-#endif

Powered by Google App Engine
This is Rietveld 408576698